From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CBF63921C1 for ; Tue, 6 Oct 2026 06:16:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791267414; cv=none; b=lRtP3onOVovc1Rz/TkzO8k/6uYc0Fj3Tuhu3c0fS7x/HpO6Qtuwe6TSP7HELuqozgs2m7Lcgia+7/bczfLYYtm6RCl2rjTUF4s7NC1tnEsu6bqEObnCsEp1aAh5MMaiqDovujAF9Fu8ul4t/TGfXMCnKb2fE5ZWtPj6XIjXiCXg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791267414; c=relaxed/simple; bh=O08cq3Y3cQTH/9SBVvDHHzM60EuXDef5UreGi/S+Czk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=tAkRAnBJRbtZKL7n22g7yRBOUKAts/EJdCZ1WBRFgxXf4WfvfUY1jTotEPVjyjm/AvMYUXL0fJN9iy8fGPYOUZs9dHG0fwARXgdmai8We3ERcFojit8i6MP5mqCIk+ONZTVYD6HjzNs+KSAFlmrHUWxppYV1oA09IzGDQ+iOFCA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Da2dVD3P; arc=none smtp.client-ip=209.85.214.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Da2dVD3P" Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2e2e064b7a6so23675025ad.0 for ; Mon, 05 Oct 2026 23:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1791267413; x=1791872213; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nSMXz7j7y1E19IYWz6Uz4I7uqLz4WSNGL5PR7f2zxls=; b=Da2dVD3PS563p8xwQLOw6gK8OyrjV2rYAyZKuiXqdKT+Qv3g21nhi25tc9qKYstYN/ N0Aw2MiWcY47xBhG5dzPZoEc02outHWaTLeOUOWvr902bYPhMAC3rKGjo8i+ICD/LlQx n/WTmqV0NhI4m4aoQXqz8qaOHD4eSBaWfHRNJeieVolLBtWP26mgiiD0NFRjcU7NgXxg AjpkmqA3mrLYoNL0A5eiTtjF1zxeoOdpy+BAqwflTxjMwq+4OpVOvNthfJm3OYUU72Op +xXG+ZGGNwToX+HxhwLSxjq6mxde1pmE7Xbjq05xme8UzOqqAXsR+1Ni4koSlXBDWF4Y F2lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791267413; x=1791872213; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nSMXz7j7y1E19IYWz6Uz4I7uqLz4WSNGL5PR7f2zxls=; b=fE+ja+Tiftxb5xZqpoVwdqE37y+txFsJxfQM/yBxZvFofMxCSR6C0E7iCuHJSBI7xS JcU59pB59ePocQX9J5P9X6Zj1IypwsTzLL1isIodynE0S1mtfBmkZ0vTabpd1D4nEKW+ fyFXSBihZtZ79VtfraGTBibPMQ4VOuAbvan3yGHE7P9Ti/qxr3ncYhUIgwTOCVeENrlv ItD6+RXzn2381XQ8tijYf5mJDuQOKgO1vraiXadRDXEAaAdk4jDA0ErdljvzgaELjnEK rl000G0f2Vy+QiI3QNWd9ny7/gvbVs+0cI/1zKAWG+pyGX2QV5w5EB5Qh1zxaRKZG1Km p+Qg== X-Forwarded-Encrypted: i=1; AKwUvByPo0aacTfT5+8rGwcSo22Pr+QEUQVc1VZztZ+jZcCvxK6Itbzk7J7KV/tdvklxzMogK5E=@vger.kernel.org X-Gm-Message-State: AFq9FYJkzAWFJULcQe5Na4rySMwXag9lyNmTNaqfXl7ncMv7zEkNcyz6 GMWH7h292Rwh7OELatda/dkfNO8DAgtOj0GmW80c5pTbAP8tgYYDwlkHHhFrHZchqhM0bkRD0MP q+jnsSA== X-Received: from plbmg12.prod.google.com ([2002:a17:903:348c:b0:2df:a429:6698]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:d4c5:b0:2e2:d09f:d770 with SMTP id d9443c01a7336-2e5dcda05a9mr4724415ad.26.1791267412437; Mon, 05 Oct 2026 23:16:52 -0700 (PDT) Date: Mon, 5 Oct 2026 23:16:51 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <36c039713c4b03c87b636635cb4c1f8b98c15eff.1783490022.git.naveen@kernel.org> <5f6bcceb-1c48-43e5-bafc-8f86676c4092@amd.com> Message-ID: Subject: Re: [RFC PATCH v3 02/27] x86/apic: Drop savic_eoi() in favor of native_apic_msr_eoi() for Secure AVIC From: Sean Christopherson To: Naveen N Rao Cc: Tom Lendacky , Borislav Petkov , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Nikunj A Dadhania , Tianyu Lan , Dave Hansen , Thomas Gleixner Content-Type: text/plain; charset="us-ascii" On Tue, Jul 14, 2026, Naveen N Rao wrote: > On Mon, Jul 13, 2026 at 12:43:45PM -0500, Tom Lendacky wrote: > > On 7/8/26 01:32, Naveen N Rao (AMD) wrote: > > > Drop savic_eoi() in favor of using the native helper that writes to the > > > APIC_EOI MSR. savic_eoi() was added mainly to be able to handle > > > level-triggered interrupts. However, it relies on APIC_TMR indicating a > > > vector to be level-triggered, but APIC_TMR can never have a bit set > > > since it is only updated when the LAPIC accepts a level-triggered > > > interrupt. In the case of a Secure AVIC SEV-SNP guest, all > > > level-triggered interrupt sources are in the VMM (emulated IOAPIC > > > primarily) and KVM accepts them on behalf of the guest resulting in the > > > APIC_TMR in KVM APIC backing page having a bit set. This is never seen > > > by the guest, which has its own private APIC backing page. As such, the > > > savic_eoi() handler is dead code. Remove it. > > > > > > Fixes: 43b6687ac877 ("x86/apic: Handle EOI writes for Secure AVIC guests") > > > Signed-off-by: Naveen N Rao (AMD) > > > > Another guest change which should be separate from this series. > > Yes, I have called this out in the cover letter. I see now that I should > have used a better subject for the cover letter though. > > > > > Is this causing issues with this hypervisor support or is just code that > > is never invoked? Do other hypervisors behave the same way and will > > removing this break them? > > This is code that is never invoked and is independent of the hypervisor. > No impact to hypervisor code. Doesn't that mean level-triggered interrupts are fundamentally incompatible with Secure AVIC? I don't see how the emulated I/O APIC will ever get an EOI.