From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5467049E5DE for ; Fri, 9 Oct 2026 09:44:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791539087; cv=none; b=Q1ZJZ/Hf7wcPe6bccZq+khKjR43GtqEhA49YTN6KsElEeXfCPeKsFKcMjNGiZehCN6KnTJPc0b1SWDkDwCVvVJeCqw5bOQV8hsJk0yTPvUOn12GCu2aE5ICySKhs7tivO37Kp4bXrL2iiasRzsnsl0OVdi9eEyugu6CT9wsUvzo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791539087; c=relaxed/simple; bh=bExytepNqeEnYoIxPmIR3Yt5a0tGUiyPzEQmZBVvvIM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=poKFhGP7u6Jcy15mhPUdFI9RoMeTEPnKJCmhRBNeH9qxp/mcs72vKvvJ/junK+QQkDOKH4bCc1L0CnCr34NuNPGCl9+EPIG4J+Xz+CU1WrxC9erOM4vHWJ4yb7VFi1eRT1OOWzzMb6fBpD+atnXFsRqDObt6n0yakOylQueFuOc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=KlDWB4qI; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=CFSIIpB7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="KlDWB4qI"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="CFSIIpB7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1791539078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ElzbfGJ6k9OnVXRhdCGGIydQGM/Gsew8hwRjohyR8bE=; b=KlDWB4qI1lbkIrF1WGNLDRsCSYEaclSfMp3aJBBLZX7H+4p8i5HxEd0ffnMW5OWFI2PkiW rvdOSnNzS92VOsH2eL3d/s6xGUaDpAbVNexHdSa2xruyM4FrZTx9nCqrZB4Q8kyA9itnkN DwFwqmn3sU/RKqqzmBZ3WTgADx41iSw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-Tf5I3y1BNAeUNQhNggza-w-1; Fri, 09 Oct 2026 05:44:36 -0400 X-MC-Unique: Tf5I3y1BNAeUNQhNggza-w-1 X-Mimecast-MFC-AGG-ID: Tf5I3y1BNAeUNQhNggza-w_1791539076 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a16dc2323cso48049195e9.3 for ; Fri, 09 Oct 2026 02:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1791539076; x=1792143876; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ElzbfGJ6k9OnVXRhdCGGIydQGM/Gsew8hwRjohyR8bE=; b=CFSIIpB7tQ+sJUoQ6DgDrCcLao8JLIyttQPk3sT6RVayfdj3gWSgL3+nuirAfZH32b BxX6uYyofsNNO9jWwt+n6RtOv30RJGu9bKx8n2B5o6B4Qycvl5MyllYD+X7cX+dWq2l2 xdTxwHrzfMNtUfHhjKh71r6Ljx0WWeCcv0A3MCjPYGM3+u9gROckYoPiQciFQt1MzunV UH88hpwxNNpxr9OBuO4tIKw1bgsuIQatk2I31Pms9xgmwjbMUyKHzKbRocfzYw+YfrJs lOA44rBTEXwjdrkTx5mPvwaioDIU+JIHkCS9mbhtQjdbATS2ZaKozx6tljEb8uc7vVWF Gi7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791539076; x=1792143876; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ElzbfGJ6k9OnVXRhdCGGIydQGM/Gsew8hwRjohyR8bE=; b=bA2x+cH7oeHvXFxm2f5TChRBts66AjvUvI+9mNSmvl3EBKXCyTs2VWuCYEoVNT/Gvo DHzg9kTJlWEUxSMrD1sNWqmU7wVe0djBxDXQh3rB4MB3+HpDzDU4YCYg+3MG2oqwc8je K+vtxR3hAzvxMh3tG3F3yC9F124weWayLWg7fuVGmuEmMvATi+t/aAh1u8vmZ5Cb87jJ 1ucXCQNgPItnLWwLM0hnfNFtKHfICEriBxFrULwPWeE2rvBernN4EmngAU5TT9iFuHxV xl4Le8mB2xsaxP7IlCeF9jm84p82imNFR8PqRG9hbTW8qzN8DUgSAAG9nLKfCgdDsk9+ j3Tw== X-Forwarded-Encrypted: i=1; AKwUvBzInw1YK6QgRJio4k1ZSW6che7M9x5HHE4jSQkwYuCPsLWtf4RqQEYRfz10T7JnP4g/Etc=@vger.kernel.org X-Gm-Message-State: AFuF++lJCgmBu9zY3aUO2hgDTwWn7RNXQB+/Ra1+xxqcM26u28PCKcoL aZWxlLS30epyG+UHtAR8cOD+muZnU0Oczt2Ltm1226YEJNImAUcf6ETIQ9RtpiU7s6JFs3Vn98T OXVphmohjG8sO+t6lntMwzsyrxXEk1z8UxxLwjDcSl98aZXrIPFlgMg== X-Gm-Gg: AYBFou2+0pR2vRVf+xuqrttZ2F5Gg91aUUlBRzY9SpCLEIMDW/A77G7VAfAwrBMvHH9 BYivV/AJ09WnkjLXM94Da2lNK0aqivSGAW6FWoOmr4svfCKtRSCbVErfqebFOTsj+ZakQAUFk9H 6fRhtjjSnA7JynEsNe48i4Cob6sxe8JW0TAqT2lFkMhb3mdbTVM0RYsV1OCQ++FovFQNT9IfZmo ZsreDxELrveuPSCshmQ8+W6A0b2xK8ObbN53l68bttMd5P6+qE3Rkua7+5a1Oo9YrDm6BRnpwrW gsDYZVO7hnrlJivdRl31jd2dzdRnu1WGxO61qCYTOKGHt4uYQAfRMijNojfVqharYMYSk30fjSz C X-Received: by 2002:a05:600c:3e0a:b0:4a0:1c10:1372 with SMTP id 5b1f17b1804b1-4a18e4aa206mr24728315e9.27.1791539075667; Fri, 09 Oct 2026 02:44:35 -0700 (PDT) X-Received: by 2002:a05:600c:3e0a:b0:4a0:1c10:1372 with SMTP id 5b1f17b1804b1-4a18e4aa206mr24727965e9.27.1791539075228; Fri, 09 Oct 2026 02:44:35 -0700 (PDT) Received: from sgarzare-redhat ([5.11.115.77]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a18bf35930sm44828935e9.13.2026.10.09.02.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2026 02:44:34 -0700 (PDT) Date: Fri, 9 Oct 2026 11:44:27 +0200 From: Stefano Garzarella To: Michal Luczaj Cc: netdev-bot+sashiko@kernel.org, stefanha@redhat.com, mst@redhat.com, jasowangio@gmail.com, eperezma@redhat.com, davem@davemloft.net, xuanzhuo@linux.alibaba.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, edumazet@kernel.org, kvm@vger.kernel.org, virtualization@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, imv4bel@gmail.com Subject: Re: [PATCH net v4] vsock: treat TCP_CLOSING as once-established Message-ID: References: <20261005-vsock-connect-reset-closing-v4-1-15d41cfda3ed@rbox.co> <179133282699.434549.6239722975007408103@kernel.org> <011a9085-0bb4-433b-afc5-9c787cde0e12@rbox.co> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <011a9085-0bb4-433b-afc5-9c787cde0e12@rbox.co> On Wed, Oct 07, 2026 at 11:24:32AM +0200, Michal Luczaj wrote: >On 10/7/26 02:27, netdev-bot+sashiko@kernel.org wrote: >> [Severity: High] >> Can vsock_connect() still reset a socket that is already linked in >> vsock_connected_table? This check only covers TCP_ESTABLISHED and >> TCP_CLOSING. At least two transports move an established socket that is >> already in the table straight to TCP_CLOSE, and neither one unlinks it. >> >> net/vmw_vsock/virtio_transport.c:virtio_vsock_reset_sock() { >> sk->sk_state = TCP_CLOSE; >> sk->sk_err = ECONNRESET; >> sk_error_report(sk); >> } >> >> virtio_vsock_event_handle() calls this for every connected socket on >> VIRTIO_VSOCK_EVENT_TRANSPORT_RESET. It does not take lock_sock(). >> >> net/vmw_vsock/vmci_transport.c:vmci_transport_handle_detach() { >> ... >> sk->sk_state = TCP_CLOSE; >> } >> sk->sk_state_change(sk); >> ... >> } > >Right, that's a known issue[1], to be handled separately. Agree! > >> [ ... ] >> sk_state does not seem to track table membership reliably. Would it be >> more robust to check sock->state == SS_CONNECTED instead (the transports >> set it together with vsock_insert_connected()), > >vsock_shutdown() complicates this. It can flip SS_CONNECTED to >SS_DISCONNECTING. Yeah, I'd avoid to use sock->state for what we are going to fix. > >> or to check membership in >> connected_table directly? That check would have to guard both the >> signal/timeout reset inside the loop and the sock_error() reset after the >> loop. > >Lack of membership check for connected_table is not the root cause of the >issue. But, sure, we can discuss adding it as a sanity check. Agree also on this! Thanks, Stefano > >[1]: https://lore.kernel.org/netdev/arpBYXWb9pohx-8v@sgarzare-redhat/ >