From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.181 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793049253; b=dV9PhKxFCWkz34xMr0t2B5NM8XPYSfSmm+oLlpDCA1L3KVoyeHl5+2RTXJW46A2ADypi gmgC3JYGT/FUd7eHMJ7bJjBz/VZ5X1fcr83ChtIyW0kjMTCUMDFB6Us9xiEqIq+11tOGU MI7fSzzjxIiU7WQNktgodq0X6rVn4a+QiKBlmDQUe5uqfqksZncFrwd3VkaRj6YAmTr01 55ymmHnwOvLc8FZr8EJ963hOzKFdZD5udFKg+iuoQPWV91uLObo8m5q5NGYTGMBJrgO/h FC9MBoAO91KChcaUaGN61cY8OnqnbH/0eso7miIkwpjuK4f5zZPgDCqLB0YzI9Nk3mw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793049253; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=gKF3hAWDK1ltcE+SHB5ZbEu9q5rcNDasVCUAn/AhQHg=; b=lYi93SLIysZf+C7guhaPku9C/0r+7JLGjkbdKTuTUta8lI19t54c2QLfkOCo/k3EnFi6 rqvYhF84G5TofmwYYpBr31fE4cP45elmjbep8U1Gdmmqs4XjKw7yGCv6j4Lgfh40oww/D MxviHJpWHNbSRXnJxievkKIu7ra+ZPtqoDublB5f+S2QgsjOZNc5SNFKYq1j2KHd3cswu 7aNp5U9Ebuv8JsyKR6tstWKzydKmn+j9i8obEKjJgtpN0d9cWlz7oL+gYo74+JWRAI88G Lzlqk9nIzYog/Lmk2igIN/xQFt0KCKsQIIV7XCLEwbqY5hdaoCFCZH8UQY4nCwaBokg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=K67nv9XJ; arc=none smtp.remote-ip=209.85.210.181 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2988D606A322 for ; Mon, 26 Oct 2026 21:14:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2988D606A322 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=K67nv9XJ Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8a070755c8cso1602587b3a.0 for ; Mon, 26 Oct 2026 14:14:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1793049252; x=1793654052; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gKF3hAWDK1ltcE+SHB5ZbEu9q5rcNDasVCUAn/AhQHg=; b=K67nv9XJ4TeaL34vMeEZnzHwkkjAJXvovbKt25dK0ARJPImK8eAJxasjllvcrO3Mvz 0GnHKSvbs2j+fu1L93vtVfYaEU7xBX2oBxVR4XSp19D8BxbS5MYCpBV1+ZjPWQ/Qou0G zCzOQQs71hCXYgkSqfxoI+w4i5o+oRk28rX4pfVUgSmX2Ghz150YtewTvUM95BqcWP5W +em5Y44xGXwMDj3h+mYQvTQ5PR6vT1Y1kvTbUxQmieHlgsnHuGeGqx3rs6CbGzAdcSyS aIIPuVbSixMCtl5PfpYxO7dwRL+PhVrWizeSZ5Cq07AOWp7dCw6lGuB6PhYEUCIwAA9v LA7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793049252; x=1793654052; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gKF3hAWDK1ltcE+SHB5ZbEu9q5rcNDasVCUAn/AhQHg=; b=C9oxtRpYhuRVVa7y44P83cuKe1pt9lGHcSTJbg/iWVCERSob6gfttY09nBqN90jt8B wjKx6ZVB6C63zcZ+dWUt25JiPBnJ7dCw2swKUnKrWgnfRJYxqQB1XmCQFTHzpJkZcybz jucytEGuncVywWRcXrCivLJf4bw01i9//8kHyY9ahO96zaf1wU/XE6HPkUOSBqpVC140 7qI+4r1k1itrjhrLRoUS4DJXiBUdLJYgd3rbowIk4aEUp4VSez85DQTFcETtL0GUT7B+ dBoMxdB63G/IzYQPYuOEm5OHbskO8oSSFQC3KQP3ssw1EvTUCYtDVRLU60ivSFaU5AHu ww8g== X-Forwarded-Encrypted: i=1; AKwUvBxr/EZPl2X9w1LNC11IGqjbSeakXlDbcvV/dwNnlo12IMmQDiT9mhlT2MF0Iqf1LW7sRek=@vger.kernel.org X-Gm-Message-State: AFq9FYK9hMwYhzF49XI4vcVhdAveEnUtYUoG5mDf1qWNRIDVdDseGQH7 WsT+AAQMxFjsPiyTwbnwuhbTN5Yc2Z7++9OKVqGoeROiMghoDAF3IFm0ZMkoQbRA5A== X-Gm-Gg: AYBFou0tUGJI8Va3Ub/0FTm23GB+EVo189ljD5ueEkd3Co36FuFAFT/4DpjlerImSiM dxlQDMU+84AxBcVyvgeIrW6kBqtKGEb3/6LR5UJVJaSJS5yJtjQuTxxNc8mdS+zbnFdXajwF8EP bUo5AdTZ4lAnOu2+6PLkIvMIOedDUzlDIYFNEk27/E1K5CyE1D9hzBgGOBcSTkzLtzX6r5TuPlk 5P6nsJyV2z8lwQ7HSPOJ/M4uKC8Em7BxnVve/EgB4xPzTcwTfjCVVV5euJDXtBpA0PwN7GsMlbU AQtAlreVVI9w+z3vgDA5XPPzMxlz/9V19VfawB7+qdNnjiI+/pGPKn7oPLlWWOAtEixTCirSJSo 8IifheXVJ31F9uyH0oG6eN3kx7N/zKhZPhDV6a5C3KjMTj/fAWq7Zvaydtya/5wAhPEPKb4qBF/ gDP5ii3Eg/XGaR8n1zZqZrTuWBQJ44VqbLjKwI0aKU50hSWw8b96x9jvSHNf/uefw0MJC660tMV kAQL1VJwYd172BrpmCvtzJGUe5/GQZ1IW7i7aO0Ohjgvh+yYj5hj36HOhojNylYlU3x3AFpLDuB as4twU+n2QPIftYYg1a931ZM78GZ5K+jX8RV8xm3hpw= X-Received: by 2002:a05:6300:6bc9:b0:3e2:3392:53e7 with SMTP id adf61e73a8af0-3e7a1b97750mr5308652637.0.1793049251805; Mon, 26 Oct 2026 14:14:11 -0700 (PDT) Received: from google.com (192.150.203.35.bc.googleusercontent.com. [35.203.150.192]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8a36b372888sm1666157b3a.30.2026.10.26.14.14.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2026 14:14:09 -0700 (PDT) Date: Mon, 26 Oct 2026 21:14:05 +0000 From: David Matlack To: tarunsahu@google.com Cc: Andrew Morton , joro@8bytes.org, Mike Rapoport , Pratyush Yadav , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Pasha Tatashin , Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] liveupdate: Replace compatibility string with a 2-bit pair feature header Message-ID: References: <20261021152527.375070-1-tarunsahu@google.com> <20261021152527.375070-4-tarunsahu@google.com> <9huzzew0el59.fsf@tarunix.c.googlers.com> X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9huzzew0el59.fsf@tarunix.c.googlers.com> On 2026-10-26 11:50 AM, tarunsahu@google.com wrote: > Right, Required bit should be source kernel payload property to tell > target kernel that the payload must be handled to correctly deserialize > the data. It should be source kernel (userspace) responsiblity to make > sure it understand the target kernel before doing liveupdate. > > Saying this, During deserialization, target kernel's required bit is not > necessary. So I propose the following truth table. > > Source hdr Target supported[i] Action > ---------- ------------------- ---------------------------------- > 00 0 or 1 Accept: feature absent in payload > 01 0 Accept: ignore the feature data > 01 1 Accept: use the feature data > 11 0 Reject: -EOPNOTSUPP > 11 1 Accept: use the feature data > 10 0 or 1 Reject: -EINVAL (invalid encoding) Yes, this matches what I had in mind for the semantics. To be explicit: the source kernel should set the bits for each Live Update based on what is actually preserved, rather than generating the header from a static per-kernel array. E.g. memfd would only mark a feature present for memfds that actually use it. That's what allows rollback to an older kernel as long as nothing being preserved depends on the new feature. But looking at this again, I think the required bit is redundant. Whether a feature can be safely ignored is a property of the feature itself, not of any particular file. Every file that has a feature present will have the same required bit for it. The only thing that actually varies per file is whether the feature is present. The required bit still has to be conveyed to the target somehow, since the kernel that needs it is the one that doesn't know about the feature. But it can be conveyed by the feature's number rather than an extra bit: split the flag space into required features and optional features, and assign each feature to one of them when it is defined. This is similar to the required_flags and optional_flags approach in struct pci_ser [1]. Keeping the same header shape as discussed with Pasha: struct kho_ser_hdr { __u32 size; /* Size of header + payload in bytes */ __u16 nr_required; /* Number of required feature bits */ __u16 nr_optional; /* Number of optional feature bits */ __u64 flags[]; /* Required bits, followed by optional bits */ }; Required feature N is bit N of flags[], and optional feature N is bit nr_required + N (using nr_required from the incoming header). The length of flags[] is DIV_ROUND_UP(nr_required + nr_optional, 64). Both spaces are numbered contiguously, so there are no gaps, and up to 64 features still fit in a 16-byte header. Each bit just means the feature is present, so the truth table becomes: Source bit Target supports Action --------------- --------------- ------------------------------ Not set - Accept: feature absent Optional set No Accept: ignore the feature data Optional set Yes Accept: use the feature data Required set No Reject: -EOPNOTSUPP Required set Yes Accept: use the feature data There is no invalid encoding left to check. [1] https://lore.kernel.org/linux-pci/20261013162529.1928093-1-dmatlack@google.com/