From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.210.171 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792625335; b=dz+acY5XJ/Y/Ksio3DaRf4Glr3kOAf9iWpGOXo3l7MptZAs4UwB3bUnZfeEsFYLpVYd3 o2vhS5JmUwvBmcJLoGBjUZjJgbJBp6dd6zRV0VXj4TXrVrFcpNittlhU9Bqy4O2OywD3B ICXXJ+NisQjFBTqSdpTqVVhVqt8Mb4z2tYJyMsUl9zr+4/bkIf1pUS5wdF+/6PQwPKJI9 kiGTIjguS4z68LCuGN6QKLrweEiUPDFuiRHjqVQE6tGWjOH/53J2d8lwTcRGoWiIt4UC9 Ptur6G62vI+oBOFBGDZ4iwsUtw/ffeBYJxfGLYUyrK+9rFjDPbz4osYrpWbIL0Uqwlw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792625335; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=j1gtu/2ECGchElAdjQsJmcTzWPpoWAuSh1B1l3W6hUU=; b=XPbNc/A6bnqCVpZpvIktxLwc9N90dWRP1L52ZNetcJEZYiPEvDglqt0WbBz2pSdj9Zo5 HDgyQUKE8WWwIc+lUL+JvvkFAZ3k5SFhxAJ/Pjh+Zi/QqVsqBe6lIqbr7B0b/u1q1cPcW 4wrcrPPnMXQ+bPZsU6HLc3Ieuas3iL/kc7H7I7JHZ7KD79ZTOTNm+G+u/Zhedc6B4+CQb VSHYeffEBCtFTecw1qKQIqJek+RWRl869WoB4ClClGwUWYEwYTKtnDBFvvy3gBsamZIU/ NPNX7Bp8Ig04kkarT2AMm6hdfTmimifU59GLOn+Ta11mVkvJQJpzx8bcqbOJ82KCPIg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=RUqvWpqO; arc=none smtp.remote-ip=209.85.210.171 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B19E606A31B for ; Wed, 21 Oct 2026 23:28:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0B19E606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20251104 header.b=RUqvWpqO Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8a052aff9e9so750457b3a.0 for ; Wed, 21 Oct 2026 16:28:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1792625334; x=1793230134; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=j1gtu/2ECGchElAdjQsJmcTzWPpoWAuSh1B1l3W6hUU=; b=RUqvWpqOjn9AAIuS71Quv64OYn+zq/6gXMfyxq9/YhV/lKLzGOgsbkTqEu40+pWUro 71/yt3sl9bDrGUIm58oa1wXgnAobiwsR/d9rX7HYc0oEMZ6hprLHHeYPUFNrXUHNp3HD eREOrf/b0l3KN49LRACMNfV+HbuCwDo60G1+32wDYI0vRh059/pM3HhRc5Na7HlGM+oC Nz7mhChY++JbMqKZt3xqdT3WAn1w9ZYo2bv3THqYKMCmmvFhqGcxfT1PSmWSYuBs5Jgt fCqmEkBylx6zAGda3LBTb5kHB6+KzNJ5GrL1+xC0yOD8oatq/Xfm+r5EVy15Xa3+ApvT 1QTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792625334; x=1793230134; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=j1gtu/2ECGchElAdjQsJmcTzWPpoWAuSh1B1l3W6hUU=; b=tyWOD8CoAhM3F1HSiVh/Wnwmtr/iT59FWEUzbwmb4NVKEcIS9OBRJ0Go04pVaBfss9 AHJ3ImnIGtYQXTmQLpdjKlcUJ1XIxWeZb26Ftn5TtJoS63s3NOVJfpidIOJPwDhZWr4m a5ifGX+7HnvyWVS0ScQZ1D36BUSdBXr7nDEiH95M9wchV3DuvLFfs/2hNPt5G0u6YHP7 nmDWIt1N0uobYRVWRhtVZo0IulTISA4IiuGJK1CAE1NC4oOfJyC7b+IrUId1wRYl77x8 unKK8YAgNN4ADPI1Or+DubUybhlFgVaIfFw+JXNPo/bGH3djQrYPZHB+xDoQDuojpbrW UlcA== X-Forwarded-Encrypted: i=1; AKwUvByB0teAEeXfxVQ0QzPqJZgOyjWCbCaAdluTeB2cjtWNOT92N6gq2beqdsVURd2pjc8hMEk=@vger.kernel.org X-Gm-Message-State: AFq9FYJagF4FuvVEuTiUtoqlV5iQfpZOReilfD7ClbaQqW7Pw0oMCSLk ygdTfNPLk+Q5SmL+b3KRU/hiptqZNZBXMLGwNtq5rb81JjVEbhoGvxim/iVU1wWMwg== X-Gm-Gg: AYBFou1AQLxNid4RuBwyjC4PJi6nbVazdNqiumC/PXnwNCfW1Zt6gvtbBoMXd4KL7mR 6gb+aGF34EFKu/eZacI/oxoLchUZjIKErwSTu68xaUZj9IfGfCR9Nc8DXJxjfEux/WxHXxMdJ/B DCtUK8lCptdfW/9LVCb3gR93vrX39RrheKDtGEVATBsPKgkmyVAtRMsntvqx0GuRE9WWKaAj+jc AdJo7h58UMhsEetW+s1WOFz1E/4NEquexhXm2JWp6VPMhy+ZNCOY5w7mskfTpGoHYAWLXPgqOyY Dn5RMm2XM+ynq5IGjJLHYZmtiPvDskIzTox58W85qC/7bcFbpJPQ+e37aLrypmv2uDswzsiscY3 jCxfHSW5A99Ne+v88tHCQmeQvOiLHtHFyTlbfetlS5BL14Aq1QcAsEoNuLWjUloKgIT3E2m7fu+ LpFHjtz2g+eZNRViiAZKIsjMKmcaMqR+qSAQRlUIfK+ujbUldsi6/oFHqWeFdZSpPEtfzl5D6uF Q0YFKB3t94a0b0KAd/HOpN3Zuq1np13MjTRlw0zblJcX8NhipI19lsYddL/sJ8RmypZDbliT432 m97088t5NeS8BapB X-Received: by 2002:a05:6a00:448b:b0:88b:7278:ebf4 with SMTP id d2e1a72fcca58-8a089dc6e77mr2781314b3a.18.1792625333734; Wed, 21 Oct 2026 16:28:53 -0700 (PDT) Received: from google.com (64.75.127.34.bc.googleusercontent.com. [34.127.75.64]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8a08933aec9sm1368611b3a.2.2026.10.21.16.28.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Oct 2026 16:28:52 -0700 (PDT) Date: Wed, 21 Oct 2026 23:28:48 +0000 From: David Matlack To: Pasha Tatashin Cc: tarunsahu@google.com, Andrew Morton , joro@8bytes.org, Mike Rapoport , Pratyush Yadav , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] liveupdate: Replace compatibility string with a 2-bit pair feature header Message-ID: References: <20261021152527.375070-1-tarunsahu@google.com> <20261021152527.375070-4-tarunsahu@google.com> <9huzecdi6go0.fsf@tarunix.c.googlers.com> X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 2026-10-21 02:50 PM, Pasha Tatashin wrote: > On Wed, Oct 21, 2026 at 2:47 PM David Matlack wrote: > > > > On Wed, Oct 21, 2026 at 11:40 AM wrote: > > > > > > Pasha Tatashin writes: > > > > > > > On Wed, Oct 21, 2026 at 11:25 AM Tarun Sahu wrote: > > > >> > > > >> LUO and its file handlers validate handed-over state with monolithic > > > >> compatibility strings ("luo-v5", "memfd-v2"). Any change to a serialized > > > >> structure, even an optional additive one, must bump the string, which > > > >> breaks live update between adjacent kernels. Replace the string in > > > >> struct luo_ser with a feature header, so that the target kernel can > > > >> accept or reject the source kernel state per feature. > > > >> > > > >> struct luo_feature_hdr is a fixed 128-byte header: the serialized > > > > > > > > This patch is all wrong; 128 bytes is far too large. For every _ser > > > > struct, we only need 8 bytes instead. > > > > > > NOO, It is not. It is intended to avoid complex mess with unnecessary > > > over-engineering. > > 128-byte per serialized struct is not starter. > > > > > > > > > > > > The first 4 bytes are the size, and the next 4 bytes are flags (i.e., > > > > 30 feature flags + 2 reserved bits for flags extension). The last two > > > > bits of the flags indicate whether an extended flags field is present. > > > > Each extended flags field is 8 bytes, and its last two bits indicate > > > > that yet another extended flags field follows. > > > > > > If we will have dynamic extension of flags, Think about this. > > > > To support dynamic extensions in a backward compatible way you want > > something like this: > > > > struct luo_feature_hdr { > > size > > flags > > __u32 size > __u32 flags > > > extensions // offset of first luo_feature_extensions (or 0) > > __u64 extensions[0] --> but the size should be specificed in > declaration macro that I showed in the next patch. I think you may have misunderstood what I meant. In my proposal, extensions is an offset to the first extension, not an array of extensions that immediately follow the header. If the extensions immediately follow the header, then the number of extensions is baked into the struct layout. Every field after them sits at an offset that depends on how many extensions there are. If we ever need one more extension, all the fields shift and old and new kernels can no longer read each other's struct. That is the problem Tarun pointed out. So in practice the number of extensions is fixed forever when the struct is first declared, and we have to guess up front how many features a struct will ever need. That's the same as Tarun's 128-byte header, just with a smaller guess. What I'm proposing is a linked list of extensions, where each link is an offset from the start of the struct. A new extension is never inserted into the middle of the struct. It is appended at the end along with the new fields that need it, like any other new field, so existing field offsets never change. Something like this: struct luo_ser_hdr { __u32 flags; __u32 next; /* Offset of first struct luo_ser_ext, or 0 */ }; struct luo_ser_ext { __u32 flags; __u32 next; /* Offset of next struct luo_ser_ext, or 0 */ }; That's the same 8 bytes as your proposal. And because "is there an extension" is next != 0 instead of reserved flag bits, all of the flag bits are available for features. For example, a struct starts out like this: struct foo_ser { struct luo_ser_hdr hdr; /* hdr.next = 0 */ __u64 a; __u64 b; }; Over time we add features and fields until the header flags run out. Then we add one more feature, FOO_FEAT_C, which needs a new field c: struct foo_ser { struct luo_ser_hdr hdr; /* hdr.next = offsetof(struct foo_ser, ext1) */ __u64 a; __u64 b; /* ... fields added for features in hdr.flags ... */ struct luo_ser_ext ext1; /* ext1.next = 0 */ __u64 c; }; - a, b, and every other existing field stay at the same offsets. Both kernels can keep casting the KHO memory directly to struct foo_ser. No memcpy() or variable offset math. - An old kernel that knows nothing about ext1 can still find it by following hdr.next, because the chain describes itself. So the old kernel can still reject the struct if ext1 has a required feature it doesn't support, and ignore ext1 otherwise. - A new kernel receiving the struct from an old kernel sees hdr.next == 0. It treats every feature in ext1 as absent and never touches c, so it never reads past the end of the old, smaller struct. The only rule for subsystems is that a field can only be accessed after checking its feature, which a LUO helper can do by walking the chain: if (luo_ser_has_feature(&ser->hdr, FOO_FEAT_C)) c = ser->c; If we keep size in the header, this is where it would be useful: LUO can check that every next offset is within size and strictly increasing (so there are no loops) before walking the chain. > > > } > > > > struct luo_feature_extentions { > > flags > > extensions // offset of next luo_feature_extensions (or 0) > > } > > > > And then an example serialization struct would be: > > > > struct foo_ser { > > struct luo_feature_hdr header; > > ... fields ... > > struct luo_feature_extension extensions1; > > ... fields ... > > struct luo_feature_extension extensions2; > > }