Re: [kvm-unit-tests PATCH 1/2] chr-testdev: Remove unused in_vq

[Andrew Jones <andrew.jones@linux.dev>]

On Thu, Oct 22, 2026 at 08:44:12PM +0000, Yosry Ahmed wrote:
> in_vq is assigned in chr_testdev_init() from vqs[0], but kvm-unit-tests
> only writes to the character device via out_vq and never consumes input
> from the host. Clang 24 warns on this with -Wunused-but-set-global:
> 
>   lib/chr-testdev.c:15:26: error: variable 'in_vq' set but not used
>   [-Werror,-Wunused-but-set-global]
> 
> Remove the unused variable.
> 
> Fixes: b412ad0d39a1 ("Introduce chr-testdev")
> Co-developed-by: Greg Thelen <gthelen@google.com>
> Signed-off-by: Greg Thelen <gthelen@google.com>
> Signed-off-by: Yosry Ahmed <yosry@kernel.org>
> ---
>  lib/chr-testdev.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/chr-testdev.c b/lib/chr-testdev.c
> index b3c641a833feb..c23fd92a46308 100644
> --- a/lib/chr-testdev.c
> +++ b/lib/chr-testdev.c
> @@ -12,7 +12,7 @@
>  #define TESTDEV_NAME "chr-testdev"
>  
>  static struct virtio_device *vcon;
> -static struct virtqueue *in_vq, *out_vq;
> +static struct virtqueue *out_vq;
>  static struct spinlock lock;
>  
>  static void __testdev_send(char *buf, unsigned int len)
> @@ -65,6 +65,5 @@ void chr_testdev_init(void)
>  		return;
>  	}
>  
> -	in_vq = vqs[0];
>  	out_vq = vqs[1];
>  }
> -- 
> 2.56.0.257.gf7497c7d27-goog
>

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>