From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.222.49 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793119207; b=WLrBqpfnweALLOFhVDCjITWwDvON/zCe7uKMGROGeR0/OkViMo/sMvvDXQIIvWICJTtt M/F0YDJPeQXR2L/gAzUxu1+IBDpWgXE3JefsRENb1pOjH8/zmWQNNWXqUoEKOHBefO6F1 RwZjD9+ajNykbvq+t9Ic9qOo2QKL9Wk7VJXBWbRfeXIUoMdBzlfqWzv+Z+A8507o7NhC2 p690hKvTvpVifOeEnrFqku6HOcs/aNhn4wNwwr7AQrfFtKlgXiGafbdbvmj15+vT4Luk7 wXiymkHCYsVXiDoxA7FEuU+Ld0VhlYVGO7PbOxvgcQwDY4Qvo9In6UmsAmXVGi2nS7Q== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793119207; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; bh=gbXuStreYRF1M4k9Su5zd2++RJBOLVmoBCN1Uwl3TZ0=; b=loWJPyWjnJadxNORw0y8C0l5EBCK9JtZ5wWXzdVlK7qqgeog+GdpoC7wRdYeWRK4cEAE QBIobtwy1veOhwMeJaGabe2vLV3JMPsxsqVXbt9ZMBkjz8Ua+QhRaPghT0k2d1cnrW72R VffaJy2Q2CfloP8ih9iX+n1cH3QhNXM9B/Jx4KXRnkHJgfFWXT1/nP39RZBfLDq1I813Q ZJrDNPJrIR6i3BL+Hsxm6UPOjcaLS8jmshJUcMw+5o8YzA5n0uT4Z5QaAZPAwarvXccg3 PCPMQIqf/8XMbNIoDU0WtGQTGnOM70gZD2bQtgDvJwcL8PBIWw8K0MbvqOqruHu00EQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=Zr7ScxU7; arc=none smtp.remote-ip=209.85.222.49 Received: from mail-ua1-f49.google.com (mail-ua1-f49.google.com [209.85.222.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C17F606A31B for ; Tue, 27 Oct 2026 16:40:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2C17F606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=Zr7ScxU7 Received: by mail-ua1-f49.google.com with SMTP id a1e0cc1a2514c-988c7371716so55158241.1 for ; Tue, 27 Oct 2026 09:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1793119206; x=1793724006; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=gbXuStreYRF1M4k9Su5zd2++RJBOLVmoBCN1Uwl3TZ0=; b=Zr7ScxU7LPpcpVmwcDfMzimPKelujj7KZMOtx1IyuU/S4C/UO70x0+DX+9QyLeh4a9 PmnVMdTOIGZWjWfC32qpJTjsEOC22/b+oVbdoj4aCBNhoaKTVm1iXV86p4vUFu1DVnFw dI3uLv4u8RrIQ01IQQfwBwKfBFnN2w4rEe4Crl4lu8CTZuhY3dzGQPAeBoRy0oN74oAs HLZUUQkXC2wsvk+R7B8NW2djal7BYB5QrNomAMvVxcHd/eztF+MMYs5OANCNnv+Bhofs R3maM6BL/pFwDUgY2Yc4GszR7T33hmDEDaQG4LcAerPIgwmq7BHN1OF57ygqfvNBL0ZG sYoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793119206; x=1793724006; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=gbXuStreYRF1M4k9Su5zd2++RJBOLVmoBCN1Uwl3TZ0=; b=rLSVQNgUHtEN1VH0NCgsuypDbxGIRN2arXG/lJUCGU0gebsiielVzjuNi1N1VjLd1B /7nzTaP+5GViiprJM8JkOep56w25/1ignJP7xZ/Bv8eSWcgX9pl9YeJuFjGRCAQRpQNN MQUCbWkKbxqtwl9LaJzggAfb0wQDzKPtXtBldi7iLXXGbgGZZifhMtwwy9pCevbU00wq 6oItuIw29vw1wbSHWgi9hvH3VQBTaW3LZRI7eYqF08Cz/8sMxM/CtxAW5FpVRJ7XJrUl CufXQAGXAmDJOgJndJ/f57ZR2JAUjlH7LprpSpF3lEeGTiz/Jpa5loq0lT+83jjA8MTx H5zg== X-Forwarded-Encrypted: i=1; AKwUvBxwPGPg0RdLYfVCe54RvuatJH8WaSqvVaUncQN3F10kUpTp9sigWumPcYZkd+F5dKKIfHw=@vger.kernel.org X-Gm-Message-State: AFq9FYLms1VG79Ow5yKHYk+BOFVZExyC25VGP68vR4AhPXDrGIy/qAjA XGGWFRGklPR550rYCnutbD7ejC/YNFLQ0CRqTysZWKCZeXKzQ4dHq2dvYEfarA6sMnM= X-Gm-Gg: AYBFou2MSkFrY4srVZk6wbng3imqN5GCR+frnbErE6Q6RpJBdP3XbrUJMzOWJsLbRhw SY+FJu7jytxk6VH04Wl5Ant6pEiwKp5q6KQBED3aD4lwvNxGN++Z04PvwVT8j5fGceaIC6Rsh0z uxNqcENq7Wa60bxqO08Q9pZ53Qf8HS/hJY9GcMB3t+hTix95zyq+JuL+0OgDojpWfT/aZTsqmMS n/EzPUHmSR5XAhjd6mdZUtcjfDpZ5z7cqnBo34Sb/GsaA1P5l3TiMjEsW2mFEmmIKfFoQV1zy/k Uw1NgOmw5ZtuLJMuhQXCw8xgv9KOY2Xkms9hlK3czM2BhhMp2unVxvCs6JmxvN9WgQrpTNTzchq 2BpKAx2yC3TMn7Ydkm7RazWIJ4Zxr7DboIrqZi18FZ2Bz++fgMUWLW5nkQKkfsuq8WaazcCRbHn 2Jd0HBZ4bvq7Qz/WbTR4Ejr1i+JzQY1QHFxJDJ31SxFu3hOxkTQEqWNxFKguXi9/H8NTW/f1kvh 1jq1Dt9CUdUh1FTCPf7zwYb0CcRj1a8QLaZe1m3RpVNUyCjsG8tCumxl6FOeGRplCkOUoKfuJUQ Od7T6zKuG8piZFg4jOv2lVVunj19CWwloMIvpgl6lx4wYFxqFf2n08iJBsZ/Lh8g7zpKOdr9S7c QKnZbmavHFfsntII1EIBdkCGORYC4cpNOt7JRXUCQXcVrIH6lJW4= X-Received: by 2002:a05:6102:5048:b0:7bf:74c1:b606 with SMTP id ada2fe7eead31-7ce5ce4227dmr3243460137.34.1793119205875; Tue, 27 Oct 2026 09:40:05 -0700 (PDT) Received: from google.com (16.49.199.35.bc.googleusercontent.com. [35.199.49.16]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-9912da2d9d1sm442866241.7.2026.10.27.09.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Oct 2026 09:40:05 -0700 (PDT) Date: Tue, 27 Oct 2026 12:40:04 -0400 From: Pasha Tatashin To: David Matlack Cc: tarunsahu@google.com, Andrew Morton , joro@8bytes.org, Mike Rapoport , Pratyush Yadav , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Pasha Tatashin , Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] liveupdate: Replace compatibility string with a 2-bit pair feature header Message-ID: References: <20261021152527.375070-1-tarunsahu@google.com> <20261021152527.375070-4-tarunsahu@google.com> <9huzzew0el59.fsf@tarunix.c.googlers.com> X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On 10-26 21:14, David Matlack wrote: > On 2026-10-26 11:50 AM, tarunsahu@google.com wrote: > > Right, Required bit should be source kernel payload property to tell > > target kernel that the payload must be handled to correctly deserialize > > the data. It should be source kernel (userspace) responsiblity to make > > sure it understand the target kernel before doing liveupdate. > > > > Saying this, During deserialization, target kernel's required bit is not > > necessary. So I propose the following truth table. > > > > Source hdr Target supported[i] Action > > ---------- ------------------- ---------------------------------- > > 00 0 or 1 Accept: feature absent in payload > > 01 0 Accept: ignore the feature data > > 01 1 Accept: use the feature data > > 11 0 Reject: -EOPNOTSUPP > > 11 1 Accept: use the feature data > > 10 0 or 1 Reject: -EINVAL (invalid encoding) > > Yes, this matches what I had in mind for the semantics. > > To be explicit: the source kernel should set the bits for each Live > Update based on what is actually preserved, rather than generating the > header from a static per-kernel array. E.g. memfd would only mark a > feature present for memfds that actually use it. That's what allows > rollback to an older kernel as long as nothing being preserved depends > on the new feature. > > But looking at this again, I think the required bit is redundant. Whether > a feature can be safely ignored is a property of the feature itself, not > of any particular file. Every file that has a feature present will have > the same required bit for it. The only thing that actually varies per > file is whether the feature is present. > > The required bit still has to be conveyed to the target somehow, since > the kernel that needs it is the one that doesn't know about the feature. > But it can be conveyed by the feature's number rather than an extra bit: > split the flag space into required features and optional features, and > assign each feature to one of them when it is defined. This is similar > to the required_flags and optional_flags approach in struct pci_ser [1]. > > Keeping the same header shape as discussed with Pasha: > > struct kho_ser_hdr { > __u32 size; /* Size of header + payload in bytes */ > __u16 nr_required; /* Number of required feature bits */ > __u16 nr_optional; /* Number of optional feature bits */ > __u64 flags[]; /* Required bits, followed by optional bits */ > }; > > Required feature N is bit N of flags[], and optional feature N is bit > nr_required + N (using nr_required from the incoming header). The length > of flags[] is DIV_ROUND_UP(nr_required + nr_optional, 64). Both spaces > are numbered contiguously, so there are no gaps, and up to 64 features > still fit in a 16-byte header. > > Each bit just means the feature is present, so the truth table becomes: > > Source bit Target supports Action > --------------- --------------- ------------------------------ > Not set - Accept: feature absent > Optional set No Accept: ignore the feature data > Optional set Yes Accept: use the feature data > Required set No Reject: -EOPNOTSUPP > Required set Yes Accept: use the feature data > I like this proposal. I bet most features are going to be either optional or required, and even if we ever have a magical sometimes-optional feature, it can have its own required flag. So, no need to pay double the cost on every flag. Just need to make sure that optional features always start from 0, in their own enum, so the offset can be computed correctly in the incoming kernel. Pasha