From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.179 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793209635; b=QGU8kLc9hs1efDxnqHP2NgCzu+7dLtVdccXcVff6OjKp4xhzL7A7DLUTxpyfuBI0NX6M XwUJljAGeKSqZYqeulzoutQ16fyoH/T0yrm7DA46M0D52VhfmE2kgC4MdmIkORQa9vPXZ lfZD69Jr9Vo9ImPEEd6IbIeJxLOxJAmoDicQ1GrlbQEjtTaCTH/kr4/OISruAvBxFjXOf L7kLknPLrjg6pXslq6GTTLB2xS10eV23lGzw30/ggTQKh/fBin6/wwo4H7VvNGVEsXDgA F10+rHPDCklhpGHyeNZZBux4pj3DXg5U/dV9HoG1GbprDTEGAiqxQbcA+Bbw4czOr2g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793209635; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:Content-Transfer-Encoding: In-Reply-To; bh=tOxsbn2WzdX0v59D7Zs82WgtkG4cFGkj3ewz31Uolyw=; b=myyWg7VR3O4aGqd/S89WrzEUYnY31TSbOqKGtzvnnAisl2lUvs2w8OtRa9b6qTX+XAmo nWiPiDROzaQsM+6EdwdmtWy77RSF4r+h7FGIWo2bwy0Nmdr+sLFXDiaox88vmtITdgWuF uj0kUGLvTsXNrVaHZ3hIvO2Wv9xWq4Rlezl+mgJUe2ZWIO0w661+0PylxNbaVfCGcY6WM XJPY30gb+ycWT+3blF3Xmh3lcF+q1ayyc4b2l08p0lXF6K4DNYUvf7A8o0zH/OW2NQDx0 83AKC7Rpv174S+5zo2aoav8MwrWpCpzNZNG/TR+/FPwiiuRlMMrFCLAfpC0Jpm5Qvrw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=TD1Tphal; arc=none smtp.remote-ip=209.85.221.179 Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33BB5606A324 for ; Wed, 28 Oct 2026 17:47:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 33BB5606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=soleen.com header.i=@soleen.com header.a=rsa-sha256 header.s=google header.b=TD1Tphal Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-5eac4855401so603036e0c.1 for ; Wed, 28 Oct 2026 10:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1793209634; x=1793814434; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tOxsbn2WzdX0v59D7Zs82WgtkG4cFGkj3ewz31Uolyw=; b=TD1Tphal9MmPmFW1OAcHF/1klWnZxSWsLxd9CIm64eCSWcLG7mG8zrPQ3838MtFr4w ZTKCFSl3LqqxJqx29pzfAWYQn1mEBphAMjxHQh2ZHPqCNzRbnJPKUjX2PRrurF12ETcu CqpI8q6ywMMFJMi3OCCZOyjdy4BmQdRRXzkxus9AfgMjqltqf3IgwcGXKdaAfyNZJuvk HngFug3/3BeoVvKeVjohQauw+bz3WMJQ37zeQDc/5Xa08m9CibytH/i9Kqr3FZ0mRD9u xfZJ4xMidWmVes15PXyLTH2PjJtuANBfb2w8XVOA8lDU7YBkZu5NB+fyh6+p652P4J5j lCkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793209634; x=1793814434; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=tOxsbn2WzdX0v59D7Zs82WgtkG4cFGkj3ewz31Uolyw=; b=ObHTShEYZhBMpbfmqhOQh5u8Q4dMNMGRq2aCCOa3jDcC8rliaLNzzrLcqqFs6DxoFv j1Yx+sWh9yrSBR6MtQJ9xNXX+hswQBT5iEux/XFi+5XCjBSYOZtCpowrZ7YTDMfPUbs6 um11JXi5aQlK/IFPGrTgsFiXnHJ7235PiNu1qZig0oS36XCXdbZ2zUneSqFsKPZxfWTG 4kD4tdNRaH1evL1hbQRl2vWjY+mUgZFwOGirzBRLpAiyysWS0CFGTQZF6cRMWueAgoTR dzDicuyjrSIvLvEdnyNWxD6MR9OTyytLkrG60hXnJl7zeu1WRDUDOy8OQtsz/ycrLKLC WTTg== X-Forwarded-Encrypted: i=1; AKwUvByQ/S7uDOk+jTFL8g1ejUQOv1U/HvcekFofXUe2t8nGZWRwEFvfOKmCK3JJP2+WTFlPbHA=@vger.kernel.org X-Gm-Message-State: AFq9FYIiGTBKdE06JOmammx7EbFUBW+6laak3WyrZSon80/+mHoZN9hn OAgSbV/J6Ms+DqLdhJV5gTXcIjrX1hnrznO7/ooWAqRR+t1uaJfHeRZdvVC/L3u/QS0= X-Gm-Gg: AYBFou0vQrMsIcQUEOh8ieUlv7exgHAC1UXMsq/EnBTn3r0hygC3GsxwwkGyw8VsLY1 BTT4Z9oqoLUzUO3Nxo9ReLMBuMTh+Fvbw3DWmpLvVq389JqdokOfN5BV88mNs3cjg50FY7IaX3v i7yxAt5Rdi1nTfAa+l9ustjfhzFdZ2aatgQ8MJpk6iijZ0asCEnkcIZkC7N97/ph0Wa77rXf1vs e5ax4Vd4oKrjeml9HVV4W+MDn6e/ND8A/CV6ozlu8meQggAFl6ULIniFCapVx3iL755iesq5z8r QbeRsDxO8suV+RijDGzGQIm9rddA8I+N8KX9FYVn2oggkoRLz5hucy04wMVPK3rTwxm/vaOJfqo QHXxWmPibA24KCMYYN3Vaqzawgj4kiRG8kQMy9bLR19sKkrZuUd2HnHL+f3Oc0QE0kMW+gLPV8G 203gq5O0WYd7sDAfZM5wBENEciftoEvy3vFg6mGXGUU2lvsrIZ8YeDsbSu8Cq0b/szTgd8wGeI/ mJz/Xcnv8K0lTyJMVlc+4XI1NbtMs9OKpzpnnNs90e03ISKMgd9KR/RoCe+Ssw9RPv1N9zHQi/e DfZCHEXE6N6f5OL7zHR+kU7zPFL8IjsHLn3k6JPByXA6APjNWDfDMeYbbGzoQrMabER4gsRsdIM zh3ixJ0oWCkD7GGAU5990NfIMV8DumbcE+vK+XQoy3DlgROjuwTeWSQ== X-Received: by 2002:a05:6122:2896:b0:5ea:fae8:e69e with SMTP id 71dfb90a1353d-5ec4cc4f065mr1774474e0c.11.1793209634129; Wed, 28 Oct 2026 10:47:14 -0700 (PDT) Received: from google.com (64.167.245.35.bc.googleusercontent.com. [35.245.167.64]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5ec57e4e556sm445088e0c.5.2026.10.28.10.47.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2026 10:47:13 -0700 (PDT) Date: Wed, 28 Oct 2026 13:47:12 -0400 From: Pasha Tatashin To: David Matlack Cc: Pratyush Yadav , Pasha Tatashin , tarunsahu@google.com, Andrew Morton , joro@8bytes.org, Mike Rapoport , maz@kernel.org, arnd@arndb.de, jgg@nvidia.com, robin.murphy@arm.com, loganodell@google.com, oupton@kernel.org, kevin.tian@intel.com, alex@shazbot.org, dwmw2@infradead.org, pbonzini@redhat.com, seanjc@google.com, will@kernel.org, Alexander Graf , Bjorn Helgaas , baolu.lu@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, sagis@google.com, linux-mm@kvack.org, kvmarm@lists.linux.dev, iommu@lists.linux.dev, linux-pci@vger.kernel.org, kexec@lists.infradead.org, skhawaja@google.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v2 3/4] liveupdate: Replace compatibility string with a 2-bit pair feature header Message-ID: References: <2vxz8q3hoicx.fsf@kernel.org> X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On 10-28 10:24, David Matlack wrote: > On Wed, Oct 28, 2026 at 10:17 AM Pratyush Yadav wrote: > > > > On Mon, Oct 26 2026, David Matlack wrote: > > > > > On 2026-10-25 04:38 PM, Pasha Tatashin wrote: > > >> On Fri, Oct 23, 2026 at 9:50 AM David Matlack wrote: > > > > > [...] > > >> The reason I care about keeping the header compact is that we are > > >> defining a foundational kernel ABI and want to use this header across > > >> almost every serialized data structure so we can evolve them later > > >> without breaking compatibility. While some top-level structs are on > > >> sparse folios today, other serialized structs are tightly packed, and > > >> we are looking to add KHO slab support in the future where tightly > > >> packed allocations will be common. > > > > > > My intuition is we will have a small number of headers per preserved > > > file and per preserved FLB. One for the top-level struct and then > > > optionally a few more for sub-structs like arch-specific data. That is > > > why I am less worried 8 bytes per header, even if we fix the folio > > > problem. > > > > > > Maybe where our visions differ is when there are collections of > > > serialized structs, like KHO blocks. For collections I don't think the > > > elements will each have their own headers. Otherwise the elements could > > > be different sizes. > > > > kho_block today doesn't store entry_size in the serialized payload. It > > relies on its caller to do so. With extensible structures, this can get > > messy. Sure, the owner of the kho_block_set can track the size somewhere > > in its payload, but perhaps we should store the size in > > kho_block_header_ser to begin with? > > +1000 > > KHO block should track the entry size automatically and not rely on > the caller. Otherwise every caller is going to have to store the entry > size in the struct that owns the KHO block, like I had to do in the > PCI v10 series :( I am fine with updating this as part of the versioning change so that we do not have to do it twice. Tarun, could you pelase include entry size change into the next version as well? Thanks, Pasha > > > Anyway, not a problem this series needs to solve, but something we > > should eventually do.