From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793377603; b=2tiXHO7MveBu3gMa09R3UbRZpL+tvpAN9zfTmFnTBbcouhVurMMgbkXZbQxNzGs4pUPs 3hkcKY3CYCN98LVfsNLjUvtcArHgz+oNqrIw+ueg8aNn8uBafBLigfSvUGipcC7n2OPD7 8wfw6gZKuRODsWprF7vAd/4wcfTCaVIt+iv3d5/cxW2IcJGGPnH1LjJw6i5GhJGby724I R4XUBoqEvBLC9d4Bc7oROt6NLmdTnW1fOofnO7HkjTltRxqALuu68KOYcsvu3MHvPRDdF TNnDrmUMvsvPcrwk8nOQgxwqM2xV4aQEnV1GJfbWZu/fUjrugTRb4qi/zhH+b8rndCA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793377603; h=Received:DKIM-Signature:Received:Received:X-ME-Sender:X-ME-Received: X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; bh=vewquYtyWMTTPew/3rciXZBlW6QyJvk7tE2jn/GyFDA=; b=rDGX0QP6G+myVTrApWz5PPKeeAYGWmeB87cb4xQi0swRlamk2UIZXw2yfN7lLLdvM3B2 ZA9bepMMxfSDHkqzMju0PNf8cSLq/qLMMFb3CrinOwYdlT0O8OncLh3Ay3AuMFP5a7qQt qHggEz+/qpdYMTjyoLZoFyudeSUEDmwlpPmOkMDy8TZDdzhX884lEsFFQKpgOQ1MEeM5s rUKbMge6dq3VRu1pycDYKKfs+60xxKBnzuVeOkYzQI9FAKuiIwYQBV7ltyQ09Ju9jaBgn 69DU7P7ccyYNqcskjxi00Br6Ftdf2ZGMxCwApCI6ZWAmWqoS2VfEfhnKLXJmCfdFLnQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=MpBV13Aa; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96D67606A31A; Fri, 30 Oct 2026 16:26:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=MpBV13Aa Received: by smtp.kernel.org (Postfix) with ESMTPSA id E835A1F0093A; Fri, 30 Oct 2026 16:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1793377603; bh=vewquYtyWMTTPew/3rciXZBlW6QyJvk7tE2jn/GyFDA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=MpBV13AanCKDXCGEU+PtepdXmUlfOazM+NDpDUNtZ1if38mgqbsOc8bg19CAqA8YF C1arMJXKa+5EK2293+KnKeo1cVclGK8iqTR+G+rRYYPwfhB1kBPkRRVeDap25OoH+V iv9HB7LKU9Ci1GSmqNgJ9TICAVYropjR9EumVcBDfOYzw9CFRAZnFgciJRvwlbPbj5 +wVyP49cQpdVsP8WnCcQQKZvsX8AR7nXYPhRH04Z1LWWTymDkJMUUeuYTRZZFZYHNi ysCjuVt6czEgMOnCf2b+VVqYYvouYEEuomVLPs+ppsTHm3BPMGqVb09jyF3PMVT2Dq +Ke+tBceINj8w== Received: from phl-compute-07.internal (phl-compute-07.internal [10.202.2.47]) by mailfauth.ams.internal (Postfix) with ESMTP id 0B6BE198003A; Fri, 30 Oct 2026 12:26:37 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-07.internal (MEProxy); Fri, 30 Oct 2026 12:26:40 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGEAIFWzBJh0zWLN17+nisZqat9HnPlshouus3rVlwm90kalixREFWaFGYcU/tF0W 3UdkUB5dz3jJ/7gphqEuNFHpf+z8VsmOxTezlK75l5ORKrVKFBa2NEgRwbYKxcTq7uyZQA W2W98B6jmDIrAQO8QKfXxueVgpiWnggcI/BJ/18E5DEgyYQ/qfuiqqVvOgCo9BjplJFuNF Cq2lBkk/rOOp1wPHM5RPg+KN1AdKgUA5k0+FVNS57TFgOuKqthusIzIHYb5h9oR56n2lPD m3bIIIT/Oa4M4xQorz7MW066A5A3Ilw7G7kLTJS6cCINZEIS17roHp+ddyILdojq+VTTHE 2MY3XR+A2l7OBM2ub01U6gbuYDHwIWf+Swtm5zC7sOi3harXi4z0yCXZWSoHi3RAKslPon otpxzqyqAYRWWojiWcoT7qUs6tH5gim5jFMxHgdLDNVKCh5KbnwHxj24tVQmrM/pPr+8RU Lse0RbqcqIjr9tKNAVnOGXNH8X5IFxsk3dnHXP064AXskGHK77xRqxNkH/D/NDqgQHTFjU 4Cn1v8+ReLH7NyMTA+RnhfJZnIw+IahQV8Cs5go/vouHMcd46srIpH0UsKCBuYR6U+VhFT 5X4IrG3Jg78xgttGn+AtH7t6hdR4nEakdA4xO0VeCYxleQm716CLywLEHQrQ X-ME-Proxy: Feedback-ID: i10464835:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Oct 2026 12:26:36 -0400 (EDT) Date: Fri, 30 Oct 2026 16:26:35 +0000 From: Kiryl Shutsemau To: Dave Hansen Cc: Challvy Tee , x86@kernel.org, linux-coco@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, regressions@lists.linux.dev, stable@vger.kernel.org, dave.hansen@linux.intel.com, rick.p.edgecombe@intel.com, vishal.l.verma@intel.com, kai.huang@intel.com, seanjc@google.com Subject: Re: [PATCH v3] x86/virt/tdx: Skip TDH.SYS.DISABLE if the TDX module is not initialized Message-ID: References: <20261030154851.907726-1-challvy.tee@gmail.com> <939b4cc7-5c7f-429d-a9be-830aa1c53ac5@intel.com> X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <939b4cc7-5c7f-429d-a9be-830aa1c53ac5@intel.com> On Fri, Oct 30, 2026 at 09:13:12AM -0700, Dave Hansen wrote: > On 10/30/26 08:48, Challvy Tee wrote: > > --- a/arch/x86/virt/vmx/tdx/tdx.c > > +++ b/arch/x86/virt/vmx/tdx/tdx.c > > @@ -2321,6 +2321,9 @@ void tdx_sys_disable(void) > > struct tdx_module_args args = {}; > > u64 ret; > > > > + if (!tdx_module_state.initialized) > > + return; > > NAK from me on this. > > If SEAMCALL is fatal then we need stronger barriers on the generic paths > to SEAMCALLs themselves, not one-off patches of the sites. I don't think the generic path is the right place for it. For every other caller, reaching a SEAMCALL on a non-TDX system means something went wrong higher up, and we want to see it. A check there that quietly returns an error hides that. Making it WARN would catch it, but then the crash path would still need its own check before the call. So gate the call on X86_FEATURE_TDX_HOST_PLATFORM, the same way paddr_is_tdx_private() does. -- Kiryl Shutsemau / Kirill A. Shutemov