Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: frankja@linux.ibm.com, imbrenda@linux.ibm.com,
	kvm@vger.kernel.org,  linux-s390@vger.kernel.org,
	pbonzini@redhat.com, shuah@kernel.org
Subject: Re: [PATCH v3 2/2] KVM: selftests: Test that KVM_RUN fails for unresolvable host faults
Date: Wed, 4 Nov 2026 17:02:41 -0800	[thread overview]
Message-ID: <auvVsbpFq4vApW1H@google.com> (raw)
In-Reply-To: <421ebe63-dd9a-4da6-a2f6-104a9473b301@linux.ibm.com>

On Tue, Oct 27, 2026, Christian Borntraeger wrote:
> Am 23.10.26 um 17:06 schrieb Sean Christopherson:
> > On Fri, Oct 23, 2026, Christian Borntraeger wrote:
> > > Add a test in which the guest writes to a shmem-backed memslot beyond
> > > the end of the file.  KVM_RUN must fail with -EFAULT.
> > > 
> > > On x86 the guest enables interrupts, and on s390 the test sets up
> > > pfault, so that KVM could handle the fault with an asynchronous page
> > > fault.  If KVM mistakes the error for a fault that needs I/O, the vCPU
> > > retries the access forever, and the test fails after a timeout.
> > > 
> > > The test is not built for LoongArch, which handles a failed mapping as
> > > an MMIO access.
> > > 
> > > Signed-off-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> > > ---
> > > I went with Seans name proposal
> > 
> > Aww, bummer.  If you posted a faulty_mcfault_face_test, I would absolutely apply
> > that and force Paolo to tell me no :-)
> 
> Sean,
> Will you pick up the fix and the selftest, shall I do it or Paolo directly?

I can grab 'em.  Were you hoping to get the fix into 7.4?  It doesn't seem super
urgent?  I was leaning towards waiting for 7.5, but tagging it for stable@.  I.e.
give ourselves a full cycle to make sure we didn't miss something, then get the
fix backported because I wouldn't be surprised if people are hitting this in
production without realizing it.

  reply	other threads:[~2026-11-05  1:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 17:58 [PATCH v2 0/2] Fix error handling for async_pf Christian Borntraeger
2026-10-20 17:58 ` [PATCH v2 1/2] KVM: Set up async page faults only for faults that need to wait Christian Borntraeger
2026-10-22  2:23   ` Sean Christopherson
2026-10-20 17:58 ` [PATCH v2 2/2] KVM: selftests: Test that KVM_RUN fails for unresolvable host faults Christian Borntraeger
2026-10-22 18:18   ` Sean Christopherson
2026-10-23 12:35     ` Christian Borntraeger
2026-10-23 14:05       ` [PATCH v3 " Christian Borntraeger
2026-10-23 15:06         ` Sean Christopherson
2026-10-27 12:31           ` Christian Borntraeger
2026-11-05  1:02             ` Sean Christopherson [this message]
2026-11-05  8:05               ` Christian Borntraeger
2026-11-03 13:09 ` [PATCH v2 0/2] Fix error handling for async_pf Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auvVsbpFq4vApW1H@google.com \
    --to=seanjc@google.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox