Re: [PATCH 5/7] debug/mem: name coroutine stacks

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Nov 09, 2026 at 01:59:05PM -0500, John Snow wrote:
> Simple enough.
> 
> RFC: Is there a better name we can give these to help tell them apart
> during analysis?

We would have to give a name to each coroutine, and then pass
it into qemu_alloc_stack. Would probably be fairly useful thing
todo as we use coroutines for lots of different things and by
way of comparison we give threads useful names too.

> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  util/oslib-posix.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/util/oslib-posix.c b/util/oslib-posix.c
> index dc001da66dd..454579c72df 100644
> --- a/util/oslib-posix.c
> +++ b/util/oslib-posix.c
> @@ -60,6 +60,7 @@
>  
>  #include "qemu/memalign.h"
>  #include "qemu/mmap-alloc.h"
> +#include "qemu/mmap-vma.h"
>  
>  #define MAX_MEM_PREALLOC_THREAD_COUNT 32
>  
> @@ -742,6 +743,8 @@ void *qemu_alloc_stack(size_t *sz)
>          abort();
>      }
>  
> +    qemu_name_vma(ptr, *sz, "coroutine-stack");
> +
>      /* Stack grows down -- guard page at the bottom. */
>      if (mprotect(ptr, pagesz, PROT_NONE) != 0) {
>          perror("failed to set up stack guard page");
> -- 
> 2.56.0
> 

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|