From: Andrew Jones <andrew.jones@linux.dev>
To: Xiang W <wangxiang@iscas.ac.cn>
Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org,
pbonzini@redhat.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 6/8] riscv: efi: Allow ACPI boots
Date: Fri, 20 Nov 2026 11:12:19 +0100 [thread overview]
Message-ID: <awAcbTDDUt5-g9YD@orel> (raw)
In-Reply-To: <20261105082035.133680-7-wangxiang@iscas.ac.cn>
On Thu, Nov 05, 2026 at 04:20:33PM +0800, Xiang W wrote:
> riscv/efi/run rejected EFI_USE_ACPI=y because CPU, timer and ISA
> discovery aborted without a DT. Those paths can now walk MADT and
> RHCT, so drop the early exit.
>
> The existing runner already omits -machine acpi=off when
s/omits/adds/
> EFI_USE_ACPI!=y. QEMU virt defaults to ACPI enabled, so no extra
> acpi=on flag is required. DT boots are unchanged: they still pass
> acpi=off.
>
> Tested with:
>
> EFI_USE_ACPI=y EFI_UEFI=/path/to/RISCV_VIRT_CODE.fd \
> ./riscv/efi/run riscv/riscv-brs.efi
>
> Signed-off-by: Xiang W <wangxiang@iscas.ac.cn>
> ---
> riscv/efi/run | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/riscv/efi/run b/riscv/efi/run
> index b9b75440..a53b3a2c 100755
> --- a/riscv/efi/run
> +++ b/riscv/efi/run
> @@ -39,11 +39,6 @@ if [ ! -f "$EFI_UEFI" ]; then
> exit 2
> fi
>
> -if [ "$EFI_USE_ACPI" = "y" ]; then
> - echo "ACPI not available"
> - exit 2
> -fi
> -
> # Remove the TEST_CASE from $@
> shift 1
>
> --
> 2.47.3
>
next prev parent reply other threads:[~2026-11-20 10:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 8:20 [kvm-unit-tests PATCH v2 0/8] riscv: ACPI boot and BRS-I SBI tests Xiang W
2026-11-05 8:20 ` [kvm-unit-tests PATCH v2 1/8] riscv: Initialize the ACPI RSDP from the EFI system table Xiang W
2026-11-05 8:20 ` [kvm-unit-tests PATCH v2 2/8] riscv: Add ACPI support for CPU initialization Xiang W
2026-11-05 8:20 ` [kvm-unit-tests PATCH v2 3/8] riscv: Add ACPI support for timer frequency discovery Xiang W
2026-11-05 8:20 ` [kvm-unit-tests PATCH v2 4/8] riscv: Add ACPI support for ISA string discovery Xiang W
2026-11-20 8:54 ` Andrew Jones
2026-11-20 9:14 ` Andrew Jones
2026-11-05 8:20 ` [kvm-unit-tests PATCH v2 5/8] riscv: Prefer SBI DBCN console with UART fallback Xiang W
2026-11-20 10:08 ` Andrew Jones
2026-11-05 8:20 ` [kvm-unit-tests PATCH v2 6/8] riscv: efi: Allow ACPI boots Xiang W
2026-11-20 10:12 ` Andrew Jones [this message]
2026-11-05 8:20 ` [kvm-unit-tests PATCH v2 7/8] riscv: initialize ISA extensions for all harts in cpu_init Xiang W
2026-11-05 8:20 ` [kvm-unit-tests PATCH v2 8/8] riscv: Add BRS SBI requirement tests Xiang W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=awAcbTDDUt5-g9YD@orel \
--to=andrew.jones@linux.dev \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thuth@redhat.com \
--cc=wangxiang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox