From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.82 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795264690; b=EJO4XQ+UWfr0LRkyCPffdel2aSPcgaDHL+Yh72Zn1JgIeBe18SypL8O70tmpWSXy7zji fttG5YIPuDanz6pukONfDvOvGg8tNbDUsQZadjnt9TeKKHAvAdlhVQCRxjKHCqZS8/zgU 6Voyt03ShF85WgCWr4MhBIIb770xGptOEc6q76FmlUI5K4dNVLg3rsn2ROleTzOPbIXwx r3ehYorcS1zmQMjqx81jMNKQsAWeBJvTIYa0EZiyTyAiCRt75Udencti3JXp8YRijr6WC Bl7PBRMgVe1TYqL9VfkU86AMUdXARCSKsFMB5dUl/8OC+2hk4uWj+VAvl2H0mxthg3A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795264690; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=m5G/QICZ24fNOzMfjvXjLK2A3CcIHloqOJ+RgXtyUT4=; b=bZHdT5D972lDgAcDM4jIYFT8o6m/rQBblJ+hdyBj/lrAIZCbc2lrl1Eq6YZ/93hUm4fT MHghaO+zd+Yj7yuXAMfkJ2OrvTsREWgbF4Ozoi78irqhzL5II/4Mj+cspWiqUsj2vJGff UTxnaRxuuN1y3ng6DWCGRNhE6lOIjxkXRsjdx0em/+J8YuLLvQZmu8sqxdKTWbGkMmGiD FKDR4r4twpZb52Fr9gaXOGeYpqz4hzX1PnaRgz7u9Fh3IEUtwmasg1fFAJX/1mEii1dyB 7SKZTrb0G3uCF4d6TK3O1SMnxNLW0r3SNZSqzsLJfJf9GsTNkI1ccjOZWdKsm87g4uA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=BVd7DUyo; arc=none smtp.remote-ip=95.215.58.82 Received: from mta1.migadu.com (out-82.mta1.migadu.com [95.215.58.82]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FFC9606A320 for ; Sat, 21 Nov 2026 12:38:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5FFC9606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=BVd7DUyo X-Envelope-To: kvm@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=rRoUO1ekAv/EnBw/LqUWxSkU357wwykHVnVwqfZsCKg=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795264687; v=1; x=1795869487; b=BVd7DUyoNQtYHAc4AxDOU+64n2ZFVG7Y9IswXb9+GmiSj5osvIXrsMxxPTJYs7PUDcCsV5L7 jJL3bm9/PTutt5R29GggzbveN3rBIOYTNJUAEIIIxDAzfmGYxgzDqf1DSZ6WuUVth46xQ5ngwMk nw83sHH+nTiiOQbBQDGuw4H0= X-Envelope-To: kvm@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 51c69ba41e2b6b86; Sat, 21 Nov 2026 12:38:07 +0000 X-Mizu-Trace-ID: 51c69ba41e2b6b86 X-Migadu-Flow: FLOW_OUT Date: Sat, 21 Nov 2026 13:37:29 +0100 From: Andrew Jones To: Gong Shuai Cc: kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Tomasz Jeznach , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Paolo Bonzini , Sean Christopherson , Jason Gunthorpe , Kevin Tian , Andrew Jones , Fangyu Yu , Tan Chi , Wu Fei , Zhao Qingye Subject: Re: [RFC PATCH v3 05/10] iommu/riscv: Add nested domain allocation Message-ID: References: <20261119132744.396426-1-gong.shuai@sanechips.com.cn> <20261119132744.396426-6-gong.shuai@sanechips.com.cn> X-Mailing-List: kvm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261119132744.396426-6-gong.shuai@sanechips.com.cn> On Thu, Nov 19, 2026 at 09:27:39PM +0800, Gong Shuai wrote: > From: Wu Fei > > A nested domain describes two-stage translation through guest and > host page tables. Iommufd exposes this domain as a nested hwpt. > > User space needs to provide the guest stage 1 configuration when > allocating a nested hwpt. Validate the configuration before storing > it for use in a physical device context. > > Signed-off-by: Wu Fei > Co-developed-by: Gong Shuai > Signed-off-by: Gong Shuai > --- > drivers/iommu/riscv/iommu.c | 153 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 153 insertions(+) > > diff --git a/drivers/iommu/riscv/iommu.c b/drivers/iommu/riscv/iommu.c > index f2305b953f71..4f8ce579ef08 100644 > --- a/drivers/iommu/riscv/iommu.c > +++ b/drivers/iommu/riscv/iommu.c > @@ -1698,8 +1698,161 @@ static void riscv_viommu_destroy(struct iommufd_viommu *viommu) > ida_free(&riscv_iommu_gscids, rv_viommu->gscid); > } > > +struct riscv_iommu_nested_domain { > + struct iommu_domain domain; > + struct riscv_viommu *viommu; > + > + u64 tc; > + u64 ta; > + u64 iosatp; > +}; > + > +#define to_riscv_iommu_nested_domain(domain) \ > + container_of(domain, struct riscv_iommu_nested_domain, domain) > + Please rename the macro parameter so it doesn't collide with the domain member name, otherwise macro expansion replaces the member name too. Thanks, drew