From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xiao Guangrong Subject: Re: [PATCH v2 8/8] migration: do not flush_compressed_data at the end of each iteration Date: Tue, 24 Jul 2018 15:29:27 +0800 Message-ID: References: <20180719121520.30026-1-xiaoguangrong@tencent.com> <20180719121520.30026-9-xiaoguangrong@tencent.com> <20180723054903.GH2491@xz-mi> <5447275f-fe48-ec8f-399c-1a5530417f65@gmail.com> <20180723083551.GK2491@xz-mi> <20180723090121.GL2491@xz-mi> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, Xiao Guangrong , dgilbert@redhat.com, qemu-devel@nongnu.org, wei.w.wang@intel.com, jiang.biao2@zte.com.cn, pbonzini@redhat.com To: Peter Xu Return-path: In-Reply-To: <20180723090121.GL2491@xz-mi> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel2=m.gmane.org@nongnu.org Sender: "Qemu-devel" List-Id: kvm.vger.kernel.org On 07/23/2018 05:01 PM, Peter Xu wrote: >> Yes, it's sufficient for current thread model, will drop it for now >> and add it at the time when the lockless mutilthread model is applied. :) > > Ah I think I see your point. Even if so I would think it better to do > any extra cleanup directly in compress_threads_save_cleanup() if > possible. > Okay, got it.