From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D924DC1B0D9 for ; Sun, 6 Dec 2020 10:18:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABECF230FA for ; Sun, 6 Dec 2020 10:18:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726962AbgLFKRq (ORCPT ); Sun, 6 Dec 2020 05:17:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:51755 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725804AbgLFKRp (ORCPT ); Sun, 6 Dec 2020 05:17:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607249779; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nlq3Q4NGrUjO0X6nFE1J9dRrjXRFJHjkBDkZG6Th+xA=; b=XZY9RGu9DLfz31sW4f2oyCEuKQ9iBL8sKZxFpdl+v2S830/y+qT63l3hswheHVxPppko+h a4n38uMWVBuXmFZHxwfcvOPVh2cAjCD8sLUaksJlV+dOHysGSUztGoPCugcZfK0InWoAhU qRXwnM2SeDgtvU8XtVgwluoBcbHCuNM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-366-9N4gIWhsO26ZTpcNRqGmhA-1; Sun, 06 Dec 2020 05:16:17 -0500 X-MC-Unique: 9N4gIWhsO26ZTpcNRqGmhA-1 Received: by mail-wr1-f70.google.com with SMTP id r11so2213464wrs.23 for ; Sun, 06 Dec 2020 02:16:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Nlq3Q4NGrUjO0X6nFE1J9dRrjXRFJHjkBDkZG6Th+xA=; b=TI0R4c/3sRrljCm4QrBr92DKwckW8i4Jdj9SFoaCwcAUVunrDyZT06jUtUCxFwe3K+ W0/Mik4cT0LS1I0BfK7B8RC8oMqY4tDCP0HF1wZsmX4Ez4QvME3WK4Aj+19R0anOAwt7 9tiwbtIyzjKAgPhrTfo9065cbU1IVUZVRzXwQqXDzYVvoNOWGANWROgAZ1Uo+HOJzwDl VllkzynVjOFdrezzQttHvQdOUIf1nGLRVZ5EckoyKyzaHQHLyFhdLXhR/58Z1/SiQkcg CUkOPeTvPhbTd1pvggJ78vUubeweKXIvLN5O7qWb9G4baIG8iqxFEXnQHm9lvvdyss+M a2FA== X-Gm-Message-State: AOAM532ikZpQXFPeJBXVdqJeX2osEi0waWpXMP6KBNVUwwadieOZ1rkm oE9BnvoXN5GiXA+UFAZv5CgLXE1aHL58OQSwpz2UCjw5pnkWuAT51HcQ3IXBy+vUCrDw5f+h8kB kT/LX/uUTWwKp X-Received: by 2002:a5d:690a:: with SMTP id t10mr14261091wru.203.1607249776383; Sun, 06 Dec 2020 02:16:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJwDq6pF9i55QF5IGljkHwdiLBLZZsbGpe+TI+yU+M6yEDL8SU6uwGNHpnOSnRBRhfU1AwJyFg== X-Received: by 2002:a5d:690a:: with SMTP id t10mr14261066wru.203.1607249776176; Sun, 06 Dec 2020 02:16:16 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id v4sm10615141wru.12.2020.12.06.02.16.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Dec 2020 02:16:15 -0800 (PST) Subject: Re: [PATCH] KVM: x86: reinstate vendor-agnostic check on SPEC_CTRL cpuid bits To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, stable@vger.kernel.org, "Denis V . Lunev" References: <20201203151516.14441-1-pbonzini@redhat.com> From: Paolo Bonzini Message-ID: Date: Sun, 6 Dec 2020 11:16:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 04/12/20 18:12, Sean Christopherson wrote: > Assuming that's > the case, adding helpers in cpuid.h to detect guest support for SPEC_CTRL (and > maybe for PRED_CMD?) would be helpful. It'd reduce duplicate code and document > that KVM allows cross-vendor emulation. The condition for SPEC_CTRL support is > especially long. That's a great idea nevertheless. Paolo