Re: [PATCH v8 00/10] Basic SEV-SNP Selftests

["Pratik R. Sampat" <prsampat@amd.com>]

Hi Sean,

On 5/2/25 4:50 PM, Sean Christopherson wrote:
> On Wed, 05 Mar 2025 16:59:50 -0600, Pratik R. Sampat wrote:
>> This patch series extends the sev_init2 and the sev_smoke test to
>> exercise the SEV-SNP VM launch workflow.
>>
>> Primarily, it introduces the architectural defines, its support in the
>> SEV library and extends the tests to interact with the SEV-SNP ioctl()
>> wrappers.
>>
>> [...]
> 
> Applied 2-9 to kvm-x86 selftests.  AIUI, the KVM side of things should already
> be fixed.  If KVM isn't fixed, I want to take that discussion/patch to a
> separate thread.
> 

Thanks for pulling these patches in.

For 1 - Ashish's commit now returns failure for this case [1].
Although, it appears that the return code isn't checked within
sev_platform_init()[2], so it shouldn't change existing behavior. In the
kselftest case, if platform init fails, the selftest will also fail — just as
it does currently too.

Regardless of what we decide on what the right behavior is, fail vs skip (I
don't mind the former) we can certainly do that over new patches rebased over
the new series.

[1]: https://lore.kernel.org/kvm/ab9a028cf232663f9fc839f48cfcf97694846c13.1742850400.git.ashish.kalra@amd.com/
[2]: https://lore.kernel.org/kvm/d8de6de80c36721ea3eb92ecac81b211f401c3b2.1742850400.git.ashish.kalra@amd.com/

> I made minor changes along the way (some details in the commits' []), please
> holler if you disagree with the end result.

Thank you for cleaning these up!

Pratik

> 
> [01/10] KVM: SEV: Disable SEV-SNP support on initialization failure
>         (no commit info)
> [02/10] KVM: selftests: SEV-SNP test for KVM_SEV_INIT2
>         https://github.com/kvm-x86/linux/commit/68ed692e3954
> [03/10] KVM: selftests: Add vmgexit helper
>         https://github.com/kvm-x86/linux/commit/c4e1a848d721
> [04/10] KVM: selftests: Add SMT control state helper
>         https://github.com/kvm-x86/linux/commit/acf064345018
> [05/10] KVM: selftests: Replace assert() with TEST_ASSERT_EQ()
>         https://github.com/kvm-x86/linux/commit/f694f30e81c4
> [06/10] KVM: selftests: Introduce SEV VM type check
>         https://github.com/kvm-x86/linux/commit/4a4e1e8e92eb
> [07/10] KVM: selftests: Add library support for interacting with SNP
>         https://github.com/kvm-x86/linux/commit/3bf3e0a52123
> [08/10] KVM: selftests: Force GUEST_MEMFD flag for SNP VM type
>         https://github.com/kvm-x86/linux/commit/b73a30cd9caa
> [09/10] KVM: selftests: Abstractions for SEV to decouple policy from type
>         https://github.com/kvm-x86/linux/commit/a5d55f783fb7
> [10/10] KVM: selftests: Add a basic SEV-SNP smoke test
>         https://github.com/kvm-x86/linux/commit/ada014f5fc67
> 
> --
> https://github.com/kvm-x86/linux/tree/next