From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA762C433EF for ; Mon, 27 Jun 2022 20:42:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240484AbiF0Um1 (ORCPT ); Mon, 27 Jun 2022 16:42:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239191AbiF0Um0 (ORCPT ); Mon, 27 Jun 2022 16:42:26 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F07481EECD; Mon, 27 Jun 2022 13:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1656362544; x=1687898544; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=teCkAY150hpKgnL1JJaIVCKfP+fzFobYu8LKDCwZNbM=; b=Th/QgnYUuHhNuyABbhvM5cmuYLVeUZHJYE31njpDaOq0D6j836+2nrWt 727CZotrw99WyOQ4P/hrZOar3ql2ArYoe8vax+2UIyP4107CmMY4RXlU5 8FnDJZeHxb3Lk4aXw7FiX/EymmhBjOnaMQP5AxoWoJ5NmLgwRfMTnnWYl fAVmeo/AqEgcxjUK2iLIt7pZxsw7i4uFPXipD05Zfx12tiWKdCTHg9Q3T xcM00NIsYCLyLjNsg+NZqkPJieM9MF1+U6QwtDs/CaWSZ8wAFqUg+cDnb gjbRmKwBjNOEFCu1cmb3EbQUgkThgvN/MYc3rqGEGk8LGZoQRg7VWKOzu A==; X-IronPort-AV: E=McAfee;i="6400,9594,10391"; a="261970165" X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="261970165" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 13:42:23 -0700 X-IronPort-AV: E=Sophos;i="5.92,227,1650956400"; d="scan'208";a="732471886" Received: from jsagoe-mobl1.amr.corp.intel.com (HELO [10.209.12.66]) ([10.209.12.66]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2022 13:42:22 -0700 Message-ID: Date: Mon, 27 Jun 2022 13:41:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 15/22] x86/virt/tdx: Allocate and set up PAMTs for TDMRs Content-Language: en-US To: Kai Huang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: seanjc@google.com, pbonzini@redhat.com, len.brown@intel.com, tony.luck@intel.com, rafael.j.wysocki@intel.com, reinette.chatre@intel.com, dan.j.williams@intel.com, peterz@infradead.org, ak@linux.intel.com, kirill.shutemov@linux.intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, isaku.yamahata@intel.com References: From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 6/27/22 03:31, Kai Huang wrote: >>> +/* Page sizes supported by TDX */ >>> +enum tdx_page_sz { >>> + TDX_PG_4K, >>> + TDX_PG_2M, >>> + TDX_PG_1G, >>> + TDX_PG_MAX, >>> +}; >> Are these the same constants as the magic numbers in Kirill's >> try_accept_one()? > try_accept_once() uses 'enum pg_level' PG_LEVEL_{4K,2M,1G} directly. They can > be used directly too, but 'enum pg_level' has more than we need here: I meant this: + switch (level) { + case PG_LEVEL_4K: + page_size = 0; + break; Because TDX_PG_4K==page_size==0, and for this: + case PG_LEVEL_2M: + page_size = 1; where TDX_PG_2M==page_size==1 See? Are Kirill's magic 0/1/2 numbers the same as TDX_PG_4K, TDX_PG_2M, TDX_PG_1G, ?