From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 1/3] KVM: nVMX: Refresh APICv secondary exec controls
 by re-calculating all of them
Date: Fri, 24 Nov 2017 00:51:04 +0100
Message-ID: <b4b6cee4-baf8-babc-330d-de1da8eddac0@redhat.com>
References: <20171122102340.7110-1-arbel.moshe@oracle.com>
 <20171122102340.7110-2-arbel.moshe@oracle.com>
 <CALMp9eQwGxFJWyKpiWC=V++WAGoV323G8cRFTdDPDquM7673Aw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        kvm list <kvm@vger.kernel.org>,
        Wanpeng Li <wanpeng.li@hotmail.com>,
        Idan Brown <idan.brown@oracle.com>,
        Liran Alon <liran.alon@oracle.com>,
        Krish Sadhukhan <krish.sadhukhan@oracle.com>
To: Jim Mattson <jmattson@google.com>,
        Arbel Moshe <arbel.moshe@oracle.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wr0-f193.google.com ([209.85.128.193]:47044 "EHLO
        mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753333AbdKWXvH (ORCPT <rfc822;kvm@vger.kernel.org>);
        Thu, 23 Nov 2017 18:51:07 -0500
Received: by mail-wr0-f193.google.com with SMTP id r2so12419816wra.13
        for <kvm@vger.kernel.org>; Thu, 23 Nov 2017 15:51:06 -0800 (PST)
In-Reply-To: <CALMp9eQwGxFJWyKpiWC=V++WAGoV323G8cRFTdDPDquM7673Aw@mail.gmail.com>
Content-Language: en-US
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 22/11/2017 18:17, Jim Mattson wrote:
> Does this change play well with the other functions that toggle
> secondary control bits without updating vmx->secondary_exec_control?
> e.g. vmx_disable_shadow_vmcs, set_current_vmptr,
> vmx_set_virtual_x2apic_mode, vmcs_set_secondary_exec_control, and
> possibly others?
> 
> Perhaps the proposed call to vmcs_write32(SECONDARY_VM_EXEC_CONTROL,
> vmx->secondary_exec_control) should instead be a call to
> vmcs_set_secondary_exec_control(vmx->secondary_exec_control)?

Yes, this is correct.

Paolo