From: Paolo Bonzini <pbonzini@redhat.com>
To: "Avi Ghosh" <aghosh@redhat.com>,
"Nick Desaulniers" <nick.desaulniers@gmail.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
josh@joshtriplett.org
Cc: avi@redhat.com, kay@vrfy.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: unneeded internal declaration
Date: Wed, 27 Sep 2017 14:50:27 +0200 [thread overview]
Message-ID: <b4f6635f-99ca-126e-0ce2-8d57a8b77fe0@redhat.com> (raw)
In-Reply-To: <CAK5g=XOWn=nUpa1Q0Oc4CntRX0LbJjbatJKLUgQOCsaba_3hNw@mail.gmail.com>
On 27/09/2017 14:39, Avi Ghosh wrote:
> Can someone remove me form this thread. I don’t know why I’m on it.
Because you are avi@redhat.com, which belonged to Avi Kivity before you.
In any case, no one can "remove you from this thread". Everyone
involved would have to remember to remove you from each and every
message that is sent on this thread. It's much simpler if you use the
"Ignore thread" or "Mute thread" functionality of your mail client.
Paolo
> On Mon, Sep 25, 2017 at 10:07 PM Nick Desaulniers
> <nick.desaulniers@gmail.com <mailto:nick.desaulniers@gmail.com>> wrote:
>
> today I noticed I was getting the warning:
>
> arch/x86/kvm/vmx.c:64:32: warning: variable 'vmx_cpu_id' is not needed
> and will not be emitted [-Wunneeded-internal-declaration]
>
> seems like this was added in commit: e9bda3b3d0ce7 "KVM: VMX:
> Auto-load on CPUs with VMX"
>
> seems like other call sites of the MODULE_DEVICE_TABLE typically get
> added to an id_table of various driver structs. Should that be the
> case here, or would a `__unused` modifier be a way forward (if so,
> please confirm, would be a good first bug for a friend)?
>
prev parent reply other threads:[~2017-09-27 12:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 3:07 unneeded internal declaration Nick Desaulniers
2017-09-26 3:35 ` Josh Triplett
2017-09-26 4:15 ` Nick Desaulniers
2017-09-26 4:25 ` [PATCH] KVM: VMX: check match table Nick Desaulniers
2017-09-26 17:12 ` Josh Triplett
2017-09-27 12:36 ` Paolo Bonzini
2017-09-30 23:22 ` Nick Desaulniers
2017-10-03 9:42 ` Paolo Bonzini
2017-10-04 2:54 ` Nick Desaulniers
2017-10-04 2:58 ` Nick Desaulniers
2017-09-27 14:14 ` kbuild test robot
2017-09-27 12:38 ` unneeded internal declaration Paolo Bonzini
[not found] ` <CAK5g=XOWn=nUpa1Q0Oc4CntRX0LbJjbatJKLUgQOCsaba_3hNw@mail.gmail.com>
2017-09-27 12:50 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4f6635f-99ca-126e-0ce2-8d57a8b77fe0@redhat.com \
--to=pbonzini@redhat.com \
--cc=aghosh@redhat.com \
--cc=avi@redhat.com \
--cc=josh@joshtriplett.org \
--cc=kay@vrfy.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick.desaulniers@gmail.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox