From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/2] KVM: page track: add a new notifier type:
 track_flush_slot
Date: Fri, 14 Oct 2016 12:43:00 +0200
Message-ID: <b6adbaa2-acf4-7485-5786-8e2355a4b5e9@redhat.com>
References: <1475998904-13456-1-git-send-email-xiaoguang.chen@intel.com>
 <1475998904-13456-2-git-send-email-xiaoguang.chen@intel.com>
 <20161009083134.GA19090@nvidia.com>
 <ad547eac-428c-751b-05c4-52002d78ecb4@redhat.com>
 <20161010180140.GA27757@nvidia.com>
 <c9d63f52-9b6f-5752-2111-773b33adc426@redhat.com>
 <1259cdba-c137-c3da-abe2-ecf51aec6738@linux.intel.com>
 <e992eb4e-0806-8f6e-851d-36eaf389a897@redhat.com>
 <ea9dffe6-7afa-4862-e46f-6f780a309e46@linux.intel.com>
 <523e1446-75f1-fe3a-d818-f7d238d57751@redhat.com>
 <5800B579.9000705@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
        Neo Jia <cjia@nvidia.com>,
        Xiaoguang Chen <xiaoguang.chen@intel.com>, kvm@vger.kernel.org,
        guangrong.xiao@intel.com, Kirti Wankhede <kwankhede@nvidia.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        "Tian, Kevin" <kevin.tian@intel.com>,
        qemu-devel <qemu-devel@nongnu.org>
To: Jike Song <jike.song@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:42634 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753912AbcJNKnG (ORCPT <rfc822;kvm@vger.kernel.org>);
        Fri, 14 Oct 2016 06:43:06 -0400
In-Reply-To: <5800B579.9000705@intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>



On 14/10/2016 12:37, Jike Song wrote:
> Hi Paolo & Alex,
> 
> IIUC, passing file descriptors means touching QEMU and the UAPI between
> QEMU and VFIO. Would you guys have a look at below draft patch? If it's
> on the correct direction, I'll send the split ones. Thanks!
> 
> --
> Thanks,
> Jike
> 
> 
> diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
> index bec694c..f715d37 100644
> --- a/hw/vfio/pci-quirks.c
> +++ b/hw/vfio/pci-quirks.c
> @@ -10,12 +10,14 @@
>   * the COPYING file in the top-level directory.
>   */
>  
> +#include <sys/ioctl.h>
>  #include "qemu/osdep.h"
>  #include "qemu/error-report.h"
>  #include "qemu/range.h"
>  #include "qapi/error.h"
>  #include "hw/nvram/fw_cfg.h"
>  #include "pci.h"
> +#include "sysemu/kvm.h"
>  #include "trace.h"
>  
>  /* Use uin32_t for vendor & device so PCI_ANY_ID expands and cannot match hw */
> @@ -1844,3 +1846,15 @@ void vfio_setup_resetfn_quirk(VFIOPCIDevice *vdev)
>          break;
>      }
>  }
> +
> +void vfio_quirk_kvmgt(VFIOPCIDevice *vdev)
> +{
> +    int vmfd;
> +
> +    if (!kvm_enabled() || !vdev->kvmgt)
> +        return;
> +
> +    /* Tell the device what KVM it attached */
> +    vmfd = kvm_get_vmfd(kvm_state);
> +    ioctl(vdev->vbasedev.fd, VFIO_SET_KVMFD, vmfd);
> +}

vfio_kvm_device_add_group is already telling the group id file
descriptor to KVM.  You can use that existing hook (whose kernel side is
virt/kvm/vfio.c).

Paolo