From: "Chen, Zide" <zide.chen@intel.com>
To: sashiko-reviews@lists.linux.dev
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH v7 7/9] KVM: x86/pmu: Restrict RDPMC passthrough to known CPUs
Date: Mon, 27 Jul 2026 16:41:52 -0500 [thread overview]
Message-ID: <b6da139a-55de-4e18-8688-9ee1cb2ec508@intel.com> (raw)
In-Reply-To: <20260727194104.16BB81F000E9@smtp.kernel.org>
On 7/27/2026 2:41 PM, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Compilation failure due to undeclared identifier `INTEL_PANTHERLAKE_R`.
> --
>
> --- Patch [7]: [PATCH v7 7/9] KVM: x86/pmu: Restrict RDPMC passthrough to known CPUs ---
> commit 4eba5efe34005f159dabad1f08138db5ccbe910e
> Author: Zide Chen <zide.chen@intel.com>
>
> KVM: x86/pmu: Restrict RDPMC passthrough to known CPUs
>
> This commit restricts KVM RDPMC passthrough to a known list of CPUs with
> audited RDPMC encodings to prevent host PMU information leaks to the guest.
> It explicitly requires RDPMC interception for unknown CPUs.
>
>> diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
>> index b983030fb910e..444a66ca33240 100644
>> --- a/arch/x86/kvm/pmu.c
>> +++ b/arch/x86/kvm/pmu.c
>> @@ -77,6 +77,21 @@ static const struct x86_cpu_id vmx_pebs_pdist_cpu[] = {
>> {}
>> };
>>
>> +/*
>> + * CPUs whose RDPMC encodings have been audited for KVM RDPMC
>> + * passthrough support.
>> + */
>> +static const struct x86_cpu_id kvm_rdpmc_known_cpus[] = {
>> + X86_MATCH_VFM(INTEL_ATOM_DARKMONT_X, NULL),
>> + X86_MATCH_VFM(INTEL_LUNARLAKE_M, NULL),
>> + X86_MATCH_VFM(INTEL_NOVALAKE, NULL),
>> + X86_MATCH_VFM(INTEL_NOVALAKE_L, NULL),
>> + X86_MATCH_VFM(INTEL_PANTHERLAKE_L, NULL),
>> + X86_MATCH_VFM(INTEL_PANTHERLAKE_R, NULL),
>
> [Severity: Low]
> Does this code build correctly on x86? It appears that INTEL_PANTHERLAKE_R
> is an undeclared macro, which could cause a compilation failure when building
> arch/x86/kvm/pmu.c.
Yes, it builds, INTEL_PANTHERLAKE_R is already in the master branch.
>
>> + X86_MATCH_VFM(INTEL_WILDCATLAKE_L, NULL),
>> + {}
>> +};
>> +
>
next prev parent reply other threads:[~2026-07-27 21:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-27 19:21 [PATCH v7 0/9] KVM: x86/pmu: Add hardware Topdown metrics support Zide Chen
2026-07-27 19:21 ` [PATCH v7 1/9] KVM: x86/pmu: Do not map fixed counters >= 3 to generic perf events Zide Chen
2026-07-27 19:21 ` [PATCH v7 2/9] KVM: x86/pmu: Support Intel fixed counter 3 on mediated vPMU Zide Chen
2026-07-27 19:51 ` sashiko-bot
2026-07-27 22:44 ` Chen, Zide
2026-07-27 19:21 ` [PATCH v7 3/9] KVM: x86/pmu: Rename and move vcpu_get_perf_capabilities() to pmu.h Zide Chen
2026-07-27 19:42 ` sashiko-bot
2026-07-27 22:19 ` Chen, Zide
2026-07-27 19:21 ` [PATCH v7 4/9] KVM: x86/pmu: Snapshot host IA32_PERF_CAPABILITIES in kvm_host Zide Chen
2026-07-27 19:44 ` sashiko-bot
2026-07-27 23:16 ` Chen, Zide
2026-07-27 19:21 ` [PATCH v7 5/9] KVM: x86/pmu: Support PERF_METRICS MSR in mediated vPMU Zide Chen
2026-07-27 19:50 ` sashiko-bot
2026-07-27 23:55 ` Chen, Zide
2026-07-27 19:21 ` [PATCH v7 6/9] KVM: x86/pmu: Move RDPMC emulation into per-vendor callbacks Zide Chen
2026-07-27 19:21 ` [PATCH v7 7/9] KVM: x86/pmu: Restrict RDPMC passthrough to known CPUs Zide Chen
2026-07-27 19:41 ` sashiko-bot
2026-07-27 21:41 ` Chen, Zide [this message]
2026-07-27 19:21 ` [PATCH v7 8/9] KVM: x86/pmu: Emulate RDPMC on performance metrics Zide Chen
2026-07-27 19:21 ` [PATCH v7 9/9] KVM: selftests: Add PERF_METRICS and fixed counter 3 tests Zide Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6da139a-55de-4e18-8688-9ee1cb2ec508@intel.com \
--to=zide.chen@intel.com \
--cc=kvm@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox