From: Thomas Huth <thuth@redhat.com>
To: Nicholas Piggin <npiggin@gmail.com>,
Andrew Jones <andrew.jones@linux.dev>
Cc: kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH 1/2] shellcheck: Fix shellcheck target with out of tree build
Date: Fri, 3 May 2024 08:31:44 +0200 [thread overview]
Message-ID: <b6f3bebd-e530-4fe7-acfd-c04fb85628d9@redhat.com> (raw)
In-Reply-To: <20240503052510.968229-2-npiggin@gmail.com>
On 03/05/2024 07.25, Nicholas Piggin wrote:
> Prepend source directory to script names, and include source directory
> in shellcheck search path.
>
> Fixes: ddfdcc3929aef ("Add initial shellcheck checking")
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 6240d8dfa..b0f7ad08b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -143,7 +143,7 @@ cscope:
>
> .PHONY: shellcheck
> shellcheck:
> - shellcheck -a run_tests.sh */run */efi/run scripts/mkstandalone.sh
> + shellcheck -P $(SRCDIR) -a $(SRCDIR)/run_tests.sh $(SRCDIR)/*/run $(SRCDIR)/*/efi/run $(SRCDIR)/scripts/mkstandalone.sh
>
> .PHONY: tags
> tags:
Tested-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-05-03 6:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 5:25 [kvm-unit-tests PATCH 0/2] shellcheck: post-merge fixups Nicholas Piggin
2024-05-03 5:25 ` [kvm-unit-tests PATCH 1/2] shellcheck: Fix shellcheck target with out of tree build Nicholas Piggin
2024-05-03 6:31 ` Thomas Huth [this message]
2024-05-03 5:25 ` [kvm-unit-tests PATCH 2/2] shellcheck: Suppress SC2209 quoting warning in config.mak Nicholas Piggin
2024-05-03 6:31 ` Thomas Huth
2024-05-03 6:35 ` [kvm-unit-tests PATCH 0/2] shellcheck: post-merge fixups Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6f3bebd-e530-4fe7-acfd-c04fb85628d9@redhat.com \
--to=thuth@redhat.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox