Re: [PATCH v3 3/7] iommu: Detaching pasid by attaching to the blocked_domain

[Yi Liu <yi.l.liu@intel.com>]

On 2024/11/7 17:35, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Monday, November 4, 2024 9:20 PM
>>
>> @@ -3404,8 +3404,18 @@ static void iommu_remove_dev_pasid(struct
>> device *dev, ioasid_t pasid,
>>   				   struct iommu_domain *domain)
>>   {
>>   	const struct iommu_ops *ops = dev_iommu_ops(dev);
>> +	struct iommu_domain *blocked_domain = ops->blocked_domain;
>> +	int ret = 1;
>> +
>> +	if (blocked_domain && blocked_domain->ops->set_dev_pasid) {
>> +		ret = blocked_domain->ops->set_dev_pasid(blocked_domain,
>> +							 dev, pasid, domain);
>> +	} else if (ops->remove_dev_pasid) {
>> +		ops->remove_dev_pasid(dev, pasid, domain);
>> +		ret = 0;
>> +	}
>>
> 
> given ops->remove_dev_pasid is already checked at attach time
> here could just call it w/o further check.

yep. A driver does not pass that check should not get here at all. So
either should be valid.

> Reviewed-by: Kevin Tian <kevin.tian@intel.com>

-- 
Regards,
Yi Liu