From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrew Jones <drjones@redhat.com>, Christoffer Dall <cdall@linaro.org>
Cc: kvm@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH kvm-unit-tests 2/3] arm64: timer: Fix test on APM X-Gene
Date: Mon, 24 Jul 2017 19:13:44 +0200 [thread overview]
Message-ID: <b7900fdf-bcc0-00af-bf5d-940eca09e4ae@redhat.com> (raw)
In-Reply-To: <20170718121527.ptemrr6mbhfwwbwe@kamzik.brq.redhat.com>
On 18/07/2017 14:15, Andrew Jones wrote:
>>
>> If we want to add a "the platform provides a timer with 56 valid bits in
>> the counter and compare register", then I think it should be a separate
>> test, and the the user can see that "basic stuff works", "architecture
>> compliance not so much" and shrug accordingly.
> Two separate tests sounds good to me. Although, if the value of 'now' is
> large enough that now + 10s will set bit 31, then a mustang run (at least
> mine) will fail - and most likely cause a lot of confusion, since it
> normally does not. We should probably attempt to address that known issue
> in some way as well.
Is the value relative to vm startup or host startup?
Paolo
next prev parent reply other threads:[~2017-07-24 17:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-13 19:20 [PATCH kvm-unit-tests 0/3] Add physical timer test Christoffer Dall
2017-07-13 19:20 ` [PATCH kvm-unit-tests 1/3] arm64: timer: Fix vtimer interrupt test Christoffer Dall
2017-07-14 7:55 ` Marc Zyngier
2017-07-14 15:43 ` Christoffer Dall
2017-07-14 15:54 ` Marc Zyngier
2017-07-13 19:20 ` [PATCH kvm-unit-tests 2/3] arm64: timer: Fix test on APM X-Gene Christoffer Dall
2017-07-14 8:04 ` Marc Zyngier
2017-07-14 15:45 ` Christoffer Dall
2017-07-18 10:05 ` Andrew Jones
2017-07-18 10:35 ` Christoffer Dall
2017-07-18 12:15 ` Andrew Jones
2017-07-24 17:13 ` Paolo Bonzini [this message]
2017-07-24 21:25 ` Christoffer Dall
2017-07-26 11:38 ` Christoffer Dall
2017-07-13 19:20 ` [PATCH kvm-unit-tests 3/3] arm64: timer: Add support for phys timer testing Christoffer Dall
2017-07-18 12:09 ` Andrew Jones
2017-07-18 13:01 ` Christoffer Dall
2017-07-18 13:23 ` Andrew Jones
2017-07-18 13:31 ` Christoffer Dall
2017-07-18 13:50 ` Andrew Jones
2017-07-18 14:15 ` Christoffer Dall
2017-07-18 14:29 ` Andrew Jones
2017-07-18 14:37 ` Christoffer Dall
2017-07-18 10:17 ` [PATCH kvm-unit-tests 0/3] Add physical timer test Andrew Jones
2017-07-18 10:42 ` Christoffer Dall
2017-07-18 12:20 ` Andrew Jones
2017-07-24 17:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7900fdf-bcc0-00af-bf5d-940eca09e4ae@redhat.com \
--to=pbonzini@redhat.com \
--cc=cdall@linaro.org \
--cc=drjones@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox