From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AB92155A52 for ; Mon, 20 Jan 2025 20:25:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737404760; cv=none; b=JnKUTxXNjwXAJ8/Xswq4x1ssLELyN6TBcWMRBFye5AvePAg3Ed685jnD4MKRf8yGbEfl5M/8j17BgTg1B2BENs6hrqkYW/h+MseOP4NH5D9FlTf/WTeoZpVJf0g8gQcVk3lmDvC/qFPorV0pWfCY9WYy+Y6auYGA8rtnXgkUQ3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737404760; c=relaxed/simple; bh=exjIalEaasD2h9X94wxNF9Y+WtDC3K6oKgwjbFa97T0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ls+Rv9nR0/XMPsGhacvPvbT8CKAimjP9pB5yzBzk1pzxsrvXYbT+EjwYU1On4kjhJl4QlX4rGVPBcPvMIQHYVRtoYqOJOFYBho5fC0rttxNBxRZZJPtV9mtJef6AfF21RiSUn/hZkJDzGqkh9SIo21RLCtahHhvxRVd6kFXDuVc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=APB9GJeN; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="APB9GJeN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737404758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SX4XhTTgvUyedWCIkQ6NCrH72F1OBgxDjm+F1qYS3K8=; b=APB9GJeN005uXxSA2m/7P9l+XDF1Ds18RZ+Kc616Rfr097Q7SwUKjMKT1QGHHO6pzTYkWO WHUdUDf1nfhq9kjawQwUZjhMdx/yzpZzYpkwRyVXVszB+h5LkOfhdgXyQ+YPd0oA3+zvLv IChhA8zY09w21e+oA5CtIyDjwOOb3Q0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-5Hq6BTWkN6eVkofpC2m2gg-1; Mon, 20 Jan 2025 15:25:56 -0500 X-MC-Unique: 5Hq6BTWkN6eVkofpC2m2gg-1 X-Mimecast-MFC-AGG-ID: 5Hq6BTWkN6eVkofpC2m2gg Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4362b9c1641so23613185e9.3 for ; Mon, 20 Jan 2025 12:25:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737404755; x=1738009555; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SX4XhTTgvUyedWCIkQ6NCrH72F1OBgxDjm+F1qYS3K8=; b=it3RWwFh2Z25H8WsD4BRTt2OFGQipadNTH1CPa0XnWQ16CesCGAufdBFU8yspK8w0P ASgjzk5mqimPd1LNKUVag3Xz66Hvb+9RGLjg+X+l2xu0Z+sCOTiuu5v4DHdF+WaK8UkQ Ga52HBkNm9yYKz22TWeHFlRNaR/tMjN8A2UYnnimSpikMR3HAGeBzAA9uSeewqRA61ss VUmhb86ZqEGvfRo0n9ARQQj8hdiDoc1Q0sPmoc9q/zt2Iuf8qRVJ2i4TZ7rHfzL9Pr5i XFW6JhQB/ptYJYMh1V0y2snWt8R7AOgXMY49mtFkpouLmWhxiiM166cUbyIJByZy1PBQ sLBw== X-Forwarded-Encrypted: i=1; AJvYcCVgjukskuN8LL9uFwdDku45L0MBT+0nQQDIdGk1LoYkb/xaZTQDrVfgst9DrNdH0jfeRFA=@vger.kernel.org X-Gm-Message-State: AOJu0YwzkiFGoGsY5J4SoCSMhM1Eb1dPz1iTWrMpFREfhcNBEHF04oIj sFN+mt6AR3obPjA6Z0IK4xmlBX+CLpoCCfAfJP/eMvSOwvC4QB3Kun+y487otp9LG9cFdnPesZl LvfQaGXw+k/nxy0+IVWndhbKTqPAQNw7B+tiRhIOgkV5AYPM/Pg== X-Gm-Gg: ASbGncvkNTWN00/lgJBIrPi95A59oO3a8UXZP2PhzudGGEmPJiYYkag0SAnN/cZwzW2 wZHo7KbSbrDkU3akF2cE3zKT6+S6eQKMjuOdZ7P1s/9NuWm38Q6j5lbGKv1NR1TJQH6tBCfvnST YHgophfa+I9tXUcmfY438zWHLu0JiscyWf3U9Akn+rC/Z9BvRq1DV+I+VxpMtoM0IGXmcJ9++2X GK7IeDXU0cH6oUlXJTndnAH5lIUYHeBVxwzym3qwcnsZ3Cok1GHZKbpflckFZG31bmoVsDHCO5L 5/ad1lj5Or8V28IrUpzx3QVR3DxaVX+kRwrFcLcMWIZyafKqmORtuv1sACf4SurfS9L01xinPyG keOZ978E0LxjRM1h4DtYrmg== X-Received: by 2002:a05:600c:4f84:b0:42c:bb96:340e with SMTP id 5b1f17b1804b1-4389144fbffmr146996425e9.31.1737404755633; Mon, 20 Jan 2025 12:25:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IFldN9qp5couChV3iXffXexECj3Up8UkpuBKDPK2O0owJVe4OWsUnJxqoWElK17bk+6BeVD8g== X-Received: by 2002:a05:600c:4f84:b0:42c:bb96:340e with SMTP id 5b1f17b1804b1-4389144fbffmr146996235e9.31.1737404755307; Mon, 20 Jan 2025 12:25:55 -0800 (PST) Received: from ?IPV6:2003:cb:c72e:e400:431d:9c08:5611:693c? (p200300cbc72ee400431d9c085611693c.dip0.t-ipconnect.de. [2003:cb:c72e:e400:431d:9c08:5611:693c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438a1ec39a3sm101412595e9.16.2025.01.20.12.25.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 12:25:53 -0800 (PST) Message-ID: Date: Mon, 20 Jan 2025 21:25:51 +0100 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] guest_memfd: Introduce an object to manage the guest-memfd with RamDiscardManager To: Peter Xu Cc: Alexey Kardashevskiy , Chenyi Qiang , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , Michael Roth , qemu-devel@nongnu.org, kvm@vger.kernel.org, Williams Dan J , Peng Chao P , Gao Chao , Xu Yilun References: <20241213070852.106092-3-chenyi.qiang@intel.com> <80ac1338-a116-48f5-9874-72d42b5b65b4@intel.com> <9dfde186-e3af-40e3-b79f-ad4c71a4b911@redhat.com> <7e60d2d8-9ee9-4e97-8a45-bd35a3b7b2a2@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.01.25 21:19, Peter Xu wrote: > On Mon, Jan 20, 2025 at 07:47:18PM +0100, David Hildenbrand wrote: >> "memory_attribute_manager" is weird if it is not memory, but memory-mapped >> I/O ... :) > > What you said sounds like a better name already than GuestMemfdManager in > this patch.. Agreed. :) To me it's ok to call MMIO as part of "memory" too, and > "attribute" can describe the shareable / private (as an attribute). I'm > guessing Yilun and Chenyi will figure that out.. Yes, calling it "attributes" popped up during RFC discussion: in theory, disacard vs. populated and shared vs. private could co-exist (maybe in the future with virtio-mem or something similar). -- Cheers, David / dhildenb