Re: [PATCH v16 22/51] KVM: x86/mmu: Pretty print PK, SS, and SGX flags in MMU tracepoints

Binbin Wu
2025-09-22T07:18:36Z

On 9/20/2025 6:32 AM, Sean Christopherson wrote:
> Add PK (Protection Keys), SS (Shadow Stacks), and SGX (Software Guard
> Extensions) to the set of #PF error flags handled via
> kvm_mmu_trace_pferr_flags. While KVM doesn't expect PK or SS #PFs
Also SGX.

> in
> particular, pretty print their names instead of the raw hex value saves
> the user from having to go spelunking in the SDM to figure out what's
> going on.
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>

Reviewed-by: Binbin Wu <binbin.wu@linux.intel.com>

> ---
> arch/x86/kvm/mmu/mmutrace.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/x86/kvm/mmu/mmutrace.h b/arch/x86/kvm/mmu/mmutrace.h
> index f35a830ce469..764e3015d021 100644
> --- a/arch/x86/kvm/mmu/mmutrace.h
> +++ b/arch/x86/kvm/mmu/mmutrace.h
> @@ -51,6 +51,9 @@
> { PFERR_PRESENT_MASK, "P" }, \
> { PFERR_WRITE_MASK, "W" }, \
> { PFERR_USER_MASK, "U" }, \
> + { PFERR_PK_MASK, "PK" }, \
> + { PFERR_SS_MASK, "SS" }, \
> + { PFERR_SGX_MASK, "SGX" }, \
> { PFERR_RSVD_MASK, "RSVD" }, \
> { PFERR_FETCH_MASK, "F" }
>