From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v2 1/5] KVM: x86: Add return value to kvm_cpuid(). Date: Thu, 17 Aug 2017 15:18:18 +0200 Message-ID: References: <1502999558-2517-1-git-send-email-yu.c.zhang@linux.intel.com> <1502999558-2517-2-git-send-email-yu.c.zhang@linux.intel.com> <9deed5e8-52e9-8634-611f-553840a43f1a@redhat.com> <1493b2f0-0e6e-2dac-5ae3-1aed3595faed@linux.intel.com> <9e7e9117-12a6-aae1-8c36-28a7a50282b6@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, rkrcmar@redhat.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, xiaoguangrong@tencent.com, joro@8bytes.org To: Yu Zhang , kvm@vger.kernel.org Return-path: In-Reply-To: <9e7e9117-12a6-aae1-8c36-28a7a50282b6@linux.intel.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 17/08/2017 14:33, Yu Zhang wrote: >>>> >>>> +enum { >>>> + NO_CHECK_LIMIT = 0, >>>> + CHECK_LIMIT = 1, >>>> +}; >>> emulate.c should not include cpuid.h. The argument can be simply a >>> bool, though. >> >> Thanks, Paolo. >> So we just use true/false in emulate.c & svm.c, is this OK? I would use true/false everywhere. >> BTW could you please > Sorry for the unfinished line. I was wondering, why can't emulate.c > include cpuid.h? The emulator should be separate from the rest of KVM, in principle it could be used by userspace too. So its interface should be as limited as possible. Paolo