From: Janosch Frank <frankja@linux.ibm.com>
To: Nico Boehr <nrb@linux.ibm.com>, kvm@vger.kernel.org
Cc: imbrenda@linux.ibm.com, thuth@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 2/2] s390x: create persistent comm-key
Date: Wed, 7 Sep 2022 08:24:34 +0200 [thread overview]
Message-ID: <ba67f05e-647c-1333-85f5-b05ee44cba74@linux.ibm.com> (raw)
In-Reply-To: <166247828688.90129.7620152734606584325@t14-nrb>
On 9/6/22 17:31, Nico Boehr wrote:
> Quoting Janosch Frank (2022-09-06 11:50:46)
>> Hmmmmmmm(TM)
>>
>> My first thought was that I'd be pretty angry if the CCK changes on a
>> distclean. But the only scenario where this would matter is when the
>> tests are provided to another system.
>>
>> I'm still a bit torn about deleting the CCK especially as there will
>> always be a CCK in the SE header no matter if we specify one or not.
>
> I really don't have a strong opinion about this. I think it makes sense to clean
> up stuff a Makefile has left behind. But I am honestly just as fine with
> removing this.
Keep it as is, we can still change it when we get complaints. :)
prev parent reply other threads:[~2022-09-07 6:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 13:15 [kvm-unit-tests PATCH v2 0/2] s390x: dump support for PV tests Nico Boehr
2022-08-25 13:15 ` [kvm-unit-tests PATCH v2 1/2] s390x: factor out common args for genprotimg Nico Boehr
2022-08-25 14:30 ` Janosch Frank
2022-08-25 13:16 ` [kvm-unit-tests PATCH v2 2/2] s390x: create persistent comm-key Nico Boehr
2022-09-06 9:50 ` Janosch Frank
2022-09-06 15:31 ` Nico Boehr
2022-09-07 6:24 ` Janosch Frank [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba67f05e-647c-1333-85f5-b05ee44cba74@linux.ibm.com \
--to=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox