From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Borntraeger Subject: Re: [PATCH v11 25/26] KVM: s390: CPU model support for AP virtualization Date: Wed, 26 Sep 2018 09:28:15 +0200 Message-ID: References: <20180925231641.4954-1-akrowiak@linux.vnet.ibm.com> <20180925231641.4954-26-akrowiak@linux.vnet.ibm.com> <2a389a01-627f-e412-c315-879fbb45f7a1@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com, frankja@linux.ibm.com, Tony Krowiak To: David Hildenbrand , Tony Krowiak , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: In-Reply-To: <2a389a01-627f-e412-c315-879fbb45f7a1@redhat.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 09/26/2018 09:15 AM, David Hildenbrand wrote: > On 26/09/2018 01:16, Tony Krowiak wrote: >> From: Tony Krowiak >> >> Introduces two new CPU model facilities to support >> AP virtualization for KVM guests: >> >> 1. AP Query Configuration Information (QCI) facility is installed. >> >> This is indicated by setting facilities bit 12 for >> the guest. The kernel will not enable this facility >> for the guest if it is not set on the host. >> >> If this facility is not set for the KVM guest, then only >> APQNs with an APQI less than 16 will be used by a Linux >> guest regardless of the matrix configuration for the virtual >> machine. This is a limitation of the Linux AP bus. >> >> 2. AP Facilities Test facility (APFT) is installed. >> >> This is indicated by setting facilities bit 15 for >> the guest. The kernel will not enable this facility for >> the guest if it is not set on the host. >> >> If this facility is not set for the KVM guest, then no >> AP devices will be available to the guest regardless of >> the guest's matrix configuration for the virtual >> machine. This is a limitation of the Linux AP bus. >> >> Signed-off-by: Tony Krowiak >> Reviewed-by: Christian Borntraeger >> Reviewed-by: Halil Pasic >> Reviewed-by: David Hildenbrand >> Tested-by: Michael Mueller >> Tested-by: Farhan Ali >> --- >> arch/s390/kvm/kvm-s390.c | 1 + >> arch/s390/tools/gen_facilities.c | 2 ++ >> 2 files changed, 3 insertions(+) >> >> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c >> index 81fd82f7626d..444965e78010 100644 >> --- a/arch/s390/kvm/kvm-s390.c >> +++ b/arch/s390/kvm/kvm-s390.c >> @@ -371,6 +371,7 @@ static void kvm_s390_cpu_feat_init(void) >> >> if (MACHINE_HAS_ESOP) >> allow_cpu_feat(KVM_S390_VM_CPU_FEAT_ESOP); >> + > > This unrelated change should be dropped. I can fixup when applying. > > (can maybe be fixed when applying) > > Apart from that looks good! >