From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD9C1C3F2D2 for ; Thu, 5 Mar 2020 16:45:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A360A20637 for ; Thu, 5 Mar 2020 16:45:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UiHt5ubD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726090AbgCEQpY (ORCPT ); Thu, 5 Mar 2020 11:45:24 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:56670 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725991AbgCEQpY (ORCPT ); Thu, 5 Mar 2020 11:45:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583426723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ctNq4CCoaNBHGFzM1KPycpQ4JYOcWX3tmGXm2KQziW8=; b=UiHt5ubDfTB64BUeKjSuLAcFzFukoQ456hxae4mvjUrZnTvBNZlfC3GoZpvekdEZO5+FJ9 cEOr7IkeOXGHQN4xtQjJrjfjSjxyPw/vNfnWQpydnRGKcEd4g8ApC1QXOXRhh0r+cda9rR Wu4ADHeR1icn4MfmNhfQEqGiFUNzRVM= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-i-d1q3nrP5mBNSNX6kKqgg-1; Thu, 05 Mar 2020 11:45:21 -0500 X-MC-Unique: i-d1q3nrP5mBNSNX6kKqgg-1 Received: by mail-wm1-f69.google.com with SMTP id f207so2301313wme.6 for ; Thu, 05 Mar 2020 08:45:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ctNq4CCoaNBHGFzM1KPycpQ4JYOcWX3tmGXm2KQziW8=; b=GOZcE68Hyf3QzyioND3PFYYfF+CuBaV0MsO0e0ppnO849Qyn7HF64lLKkajsfv6E9g EjeS0nYkNNqW1pvKL8FLjFtmKKGVxk9+DlmK4eOWQUaHT+KtCUNso+K0AT8Id+m8bCGM ffxxOmKHK2ZuxUw1+tpy2jTTd9ImOOkOcTHwnkky5ez6W9Ad0AfZUeeqzFSm8uYB0Xfc D5vYo85jI9yRa3BiEzI6UjyhB9sdnZpv/F5jWgR0T5pEpR4+YR2NIyKcCO3cTqffGwUZ /kM3zO01JA77ShuOLhfenXVkKInqPtha0MsMca9GEEG+yC+zIyIsr4zShqSlQEl7d+Kw i2nw== X-Gm-Message-State: ANhLgQ3TEjbGCF2XJmfq5//NmgWAhypsyRs1CeLygFEt5bkt7+h0uGp2 14Y89zgjAFCq8mXHtC9bLBQVUjh4XbrbG7UCiUPBCesdNZMECWJKqwcao3UC3k+2xCnrOvLz5lP wAbwbxRKz/myO X-Received: by 2002:a05:600c:4108:: with SMTP id j8mr10410541wmi.188.1583426720209; Thu, 05 Mar 2020 08:45:20 -0800 (PST) X-Google-Smtp-Source: ADFU+vtqIAyf6ANiV/6hH7zyPHEAgMKe6UD6gdYRfrFD40jdUM+Pii4EnaD7zdAuV588Uc8uu6P6iQ== X-Received: by 2002:a05:600c:4108:: with SMTP id j8mr10410494wmi.188.1583426719539; Thu, 05 Mar 2020 08:45:19 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:9def:34a0:b68d:9993? ([2001:b07:6468:f312:9def:34a0:b68d:9993]) by smtp.gmail.com with ESMTPSA id m19sm9856625wmc.34.2020.03.05.08.45.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Mar 2020 08:45:18 -0800 (PST) Subject: Re: [PATCH v2 1/4] x86/kvm/hyper-v: Align the hcall param for kvm_hyperv_exit To: Jon Doron Cc: kvm@vger.kernel.org, linux-hyperv@vger.kernel.org, Vitaly Kuznetsov References: <20200305140142.413220-1-arilou@gmail.com> <20200305140142.413220-2-arilou@gmail.com> <09762184-9913-d334-0a33-b76d153bc371@redhat.com> <0edfee0e-01ee-bb62-5fc5-67d7d45ec192@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 5 Mar 2020 17:45:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 05/03/20 16:52, Jon Doron wrote: > bah you are right sorry :( but if ill do that ill break userspace no? No, you'd just be making the padding explicit. Paolo > > On Thu, Mar 5, 2020 at 5:30 PM Paolo Bonzini wrote: >> On 05/03/20 15:53, Jon Doron wrote: >>> Vitaly recommended we will align the struct to 64bit... >> Oh, then I think you actually should add a padding after "__u32 type;" >> and "__u32 msr;" if you want to make it explicit. The patch, as is, is >> not aligning anything, hence my confusion.