From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E46DA31 for ; Mon, 16 Jun 2025 14:03:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750082598; cv=none; b=o1w3ChtA8vwYeAmL2LqyrMU7Krq92Ke3J9iCMrSbI1ZK+ZePZllfRHedELo7HxxMaFhqu9Ko2E0G9Es733DgByq21oIf5NLVsczrGJ1H69BtdS/3mJCgeznQ3ySNyS2mE/F1RW1eYpQTAvceu3nNYPGnRKlSmWhMiaQfAIArKyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750082598; c=relaxed/simple; bh=bMDMUwzmTP6X3VCRGfbe+JisOCB3Bv7nBVc08LfFDdc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sOr301x4qrP1T6UZasaXO7q3qOa5I1yRIAUyHRSi76RFr1aa5ehNyX//x8ANweukcJiwL+kSEZPEfzVHzQ3r09+ZE8liqyKE2gvbHkcfALoohe6LL7cYP4lbgL62g8hAa+fxCQqxJv7GO7X/9KkWq4Kw/MJ8dRKzFWx3UfeXruQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QPSB21jI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QPSB21jI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750082596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YYMGqbsE8xuxr6+j51x+v+1ZVm8RBXnD2cwLTgvX0ig=; b=QPSB21jITtdFdUuosM2G5CwnkpToL0MPrGKNTNkH2RRck3fjULgOpyKwVvubXoCWYuIkI0 bQH7bUk1dYRHfJQYUlFNIihvUrZ2GhjkCwZl76BbqN3uNNbyLVCufPACmBseDpHlp8i4Co vxPTXK4X+mvalK0jtjNwAS/kiW5elG0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-uZhXOewUPeeoiRLyQeCQGQ-1; Mon, 16 Jun 2025 10:03:14 -0400 X-MC-Unique: uZhXOewUPeeoiRLyQeCQGQ-1 X-Mimecast-MFC-AGG-ID: uZhXOewUPeeoiRLyQeCQGQ_1750082593 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-450db029f2aso21510045e9.3 for ; Mon, 16 Jun 2025 07:03:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750082593; x=1750687393; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YYMGqbsE8xuxr6+j51x+v+1ZVm8RBXnD2cwLTgvX0ig=; b=kErwtujPWPltlu4f30NIzZp/tNIYxqY6LMArdvBesTDJy8AM013HZ4hyFTcTzbE5EW LeToyP4JIsauJ3PZFWdN4wBrE4OlgWwAnDIPPuv4UHT7pxdk3EzboF4RHrXwjQeUPy2C p8JRjUk8t+UNFd51Wj/RHasbsBUGvYwEkR6mMO4+ALRaxJp/55SUYNjn0LB7MUgOIBeA HfbNLJL1EjgBL0alk6UK42Z4N/pm9lvJnhlMhlOCMLCPb0l3Vfm2TwyAq3vglBYp4Yc0 uGV5yw6wOqDeVibEsQA7m2SAqy5wCO3/zN1Tg3jS5/pgCcvGpBIErppPORhJPX4f8zdv wS2A== X-Gm-Message-State: AOJu0Ywa1Y051Q3iXqZ9Y5a1zGEPNXejdRYAtECyzfsROxMGTUvO5/EK KPdPDpQXgSkHznK9fkIPL7+qJIAtYncUa8VI0J/y9Y6T69o5ANNO8D8Fa1EotdkdS52rBG5qQ0T 5QDsC8kc6Z1WDn/PLLtqDbLkbQe0lp0SQc6QWCtNUQELN4E/N5ESSjg== X-Gm-Gg: ASbGncuryofjDJgtRBEP6QG++o6kS+Kv+j3r/4Y1Grvcn/wyol1wj7x7qTqqLHgnyTh LUBN1InJpYS71RszyFufNCAythvztLrRptIb2zTXJmdNztocx21Yeg7cOfLSClw8QiNqeDx4bPK xq8fUP/0PZPjW2yLCuRYxc4ag2YI8bb7PueqtCUJ/G7x1IbSRZwfrvQwndm90HGiwYnSzu3Cryo gfQghD+PhZdrzH7gPUDbRxQ6dTa7NPlqLnXJkjQIXkj11SOpkzKRBe2S6TW0Ez2n4YxVqNHfc6a Dt6p3PI+IjBt0jIK0cRaMGXpyou1IkXLZrez/aqBYLrCovaEKnWIAWIb0MMPS0VvfizpMrHdfIu prtdgVGvfn6iDbW60VD2x8iPEvjiRjaYlWvxzAME2dSJYAB8= X-Received: by 2002:a05:600c:6099:b0:43c:eeee:b70a with SMTP id 5b1f17b1804b1-4533cadb4femr70242675e9.22.1750082592855; Mon, 16 Jun 2025 07:03:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEU7FGgcnPjUGGNJEehoPKJ/KEDmy26JrIQxnf6DDI7pUi8iBQVhJ8twwNg8wb4K6FBIpsl5w== X-Received: by 2002:a05:600c:6099:b0:43c:eeee:b70a with SMTP id 5b1f17b1804b1-4533cadb4femr70241455e9.22.1750082591911; Mon, 16 Jun 2025 07:03:11 -0700 (PDT) Received: from ?IPV6:2003:d8:2f25:bd00:949:b5a9:e02a:f265? (p200300d82f25bd000949b5a9e02af265.dip0.t-ipconnect.de. [2003:d8:2f25:bd00:949:b5a9:e02a:f265]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568a547ecsm11376603f8f.17.2025.06.16.07.03.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jun 2025 07:03:11 -0700 (PDT) Message-ID: Date: Mon, 16 Jun 2025 16:03:08 +0200 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 08/18] KVM: guest_memfd: Allow host to map guest_memfd pages To: Ira Weiny , Sean Christopherson , Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com References: <20250611133330.1514028-1-tabba@google.com> <20250611133330.1514028-9-tabba@google.com> <68501fa5dce32_2376af294d1@iweiny-mobl.notmuch> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <68501fa5dce32_2376af294d1@iweiny-mobl.notmuch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 16.06.25 15:44, Ira Weiny wrote: > Sean Christopherson wrote: >> On Wed, Jun 11, 2025, Fuad Tabba wrote: >>> This patch enables support for shared memory in guest_memfd, including >> >> Please don't lead with with "This patch", simply state what changes are being >> made as a command. >> >>> mapping that memory from host userspace. >> >>> This functionality is gated by the KVM_GMEM_SHARED_MEM Kconfig option, >>> and enabled for a given instance by the GUEST_MEMFD_FLAG_SUPPORT_SHARED >>> flag at creation time. >> >> Why? I can see that from the patch. >> >> This changelog is way, way, waaay too light on details. Sorry for jumping in at >> the 11th hour, but we've spent what, 2 years working on this? >> >>> Reviewed-by: Gavin Shan >>> Acked-by: David Hildenbrand >>> Co-developed-by: Ackerley Tng >>> Signed-off-by: Ackerley Tng >>> Signed-off-by: Fuad Tabba >>> --- >>> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >>> index d00b85cb168c..cb19150fd595 100644 >>> --- a/include/uapi/linux/kvm.h >>> +++ b/include/uapi/linux/kvm.h >>> @@ -1570,6 +1570,7 @@ struct kvm_memory_attributes { >>> #define KVM_MEMORY_ATTRIBUTE_PRIVATE (1ULL << 3) >>> >>> #define KVM_CREATE_GUEST_MEMFD _IOWR(KVMIO, 0xd4, struct kvm_create_guest_memfd) >>> +#define GUEST_MEMFD_FLAG_SUPPORT_SHARED (1ULL << 0) >> >> I find the SUPPORT_SHARED terminology to be super confusing. I had to dig quite >> deep to undesrtand that "support shared" actually mean "userspace explicitly >> enable sharing on _this_ guest_memfd instance". E.g. I was surprised to see >> >> IMO, GUEST_MEMFD_FLAG_SHAREABLE would be more appropriate. But even that is >> weird to me. For non-CoCo VMs, there is no concept of shared vs. private. What's >> novel and notable is that the memory is _mappable_. Yeah, yeah, pKVM's use case >> is to share memory, but that's a _use case_, not the property of guest_memfd that >> is being controlled by userspace. >> >> And kvm_gmem_memslot_supports_shared() is even worse. It's simply that the >> memslot is bound to a mappable guest_memfd instance, it's that the guest_memfd >> instance is the _only_ entry point to the memslot. >> >> So my vote would be "GUEST_MEMFD_FLAG_MAPPABLE", and then something like > > If we are going to change this; FLAG_MAPPABLE is not clear to me either. > The guest can map private memory, right? I see your point about shared > being overloaded with file shared but it would not be the first time a > term is overloaded. kvm_slot_has_gmem() does makes a lot of sense. > > If it is going to change; how about GUEST_MEMFD_FLAG_USER_MAPPABLE? If "shared" is not good enough terminology ... ... can we please just find a way to name what this "non-private" memory is called? That something is mappable into $whatever is not the right way to look at this IMHO. As raised in the past, we can easily support read()/write()/etc to this non-private memory. I'll note, the "non-private" memory in guest-memfd behaves just like ... the "shared" memory in shmem ... well, or like other memory in memfd. (which is based on mm/shmem.c). "Private" is also not the best way to describe the "protected\encrypted" memory, but that ship has sailed with KVM_MEMORY_ATTRIBUTE_PRIVATE. I'll further note that in the doc of KVM_SET_USER_MEMORY_REGION2 we talk about "private" vs "shared" memory ... so that would have to be improved as well. -- Cheers, David / dhildenb