From: Junaid Shahid <junaids@google.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 2/3] kvm: rename last argument to kvm_get_dirty_log_protect
Date: Mon, 26 Nov 2018 14:49:10 -0800 [thread overview]
Message-ID: <bc76c8d5-2e79-65c8-2b7b-46f2e8d8b001@google.com> (raw)
In-Reply-To: <1543251253-24762-3-git-send-email-pbonzini@redhat.com>
On 11/26/2018 08:54 AM, Paolo Bonzini wrote:
> When manual dirty log reprotect will be enabled, kvm_get_dirty_log_protect's
> pointer argument will always be false on exit, because no TLB flush is needed
> until the manual re-protection operation. Rename it from "is_dirty" to "flush",
> which more accurately tells the caller what they have to do with it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> arch/mips/kvm/mips.c | 6 +++---
> arch/x86/kvm/x86.c | 6 +++---
> include/linux/kvm_host.h | 2 +-
> virt/kvm/arm/arm.c | 6 +++---
> virt/kvm/kvm_main.c | 6 +++---
> 5 files changed, 13 insertions(+), 13 deletions(-)
>
Reviewed-by: Junaid Shahid <junaids@google.com>
next prev parent reply other threads:[~2018-11-26 22:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 16:54 [PATCH 0/3] kvm: split retrieval and clearing of dirty log Paolo Bonzini
2018-11-26 16:54 ` [PATCH 1/3] kvm: make KVM_CAP_ENABLE_CAP_VM architecture agnostic Paolo Bonzini
2018-11-26 17:50 ` Cornelia Huck
2018-11-26 22:37 ` Junaid Shahid
2018-11-26 16:54 ` [PATCH 2/3] kvm: rename last argument to kvm_get_dirty_log_protect Paolo Bonzini
2018-11-26 22:49 ` Junaid Shahid [this message]
2018-11-26 16:54 ` [PATCH 3/3] kvm: introduce manual dirty log reprotect Paolo Bonzini
2018-11-27 5:04 ` Junaid Shahid
2018-11-27 10:11 ` Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2018-11-28 11:42 [PATCH v2 0/3] kvm: split retrieval and clearing of dirty log Paolo Bonzini
2018-11-28 11:42 ` [PATCH 2/3] kvm: rename last argument to kvm_get_dirty_log_protect Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc76c8d5-2e79-65c8-2b7b-46f2e8d8b001@google.com \
--to=junaids@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox