From: Andrea Arcangeli <andrea@qumranet.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <clameter@sgi.com>,
Jack Steiner <steiner@sgi.com>,
Robin Holt <holt@sgi.c
Cc: andrea@qumranet.com
Subject: [PATCH 1 of 3] list_del_init_rcu
Date: Thu, 05 Jun 2008 17:36:08 +0200 [thread overview]
Message-ID: <becc195598f802256a03.1212680168@duo.random> (raw)
In-Reply-To: <patchbomb.1212680167@duo.random>
From: Andrea Arcangeli <andrea@qumranet.com>
Introduces list_del_init_rcu and documents it (fixes a comment for
list_del_rcu too).
Signed-off-by: Andrea Arcangeli <andrea@qumranet.com>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
---
diff -r 86e3ce291996 -r becc195598f8 include/linux/list.h
--- a/include/linux/list.h Wed Jun 04 10:35:03 2008 -0700
+++ b/include/linux/list.h Thu Jun 05 17:30:14 2008 +0200
@@ -747,7 +747,7 @@ static inline void hlist_del(struct hlis
* or hlist_del_rcu(), running on this same list.
* However, it is perfectly legal to run concurrently with
* the _rcu list-traversal primitives, such as
- * hlist_for_each_entry().
+ * hlist_for_each_entry_rcu().
*/
static inline void hlist_del_rcu(struct hlist_node *n)
{
@@ -760,6 +760,34 @@ static inline void hlist_del_init(struct
if (!hlist_unhashed(n)) {
__hlist_del(n);
INIT_HLIST_NODE(n);
+ }
+}
+
+/**
+ * hlist_del_init_rcu - deletes entry from hash list with re-initialization
+ * @n: the element to delete from the hash list.
+ *
+ * Note: list_unhashed() on the node return true after this. It is
+ * useful for RCU based read lockfree traversal if the writer side
+ * must know if the list entry is still hashed or already unhashed.
+ *
+ * In particular, it means that we can not poison the forward pointers
+ * that may still be used for walking the hash list and we can only
+ * zero the pprev pointer so list_unhashed() will return true after
+ * this.
+ *
+ * The caller must take whatever precautions are necessary (such as
+ * holding appropriate locks) to avoid racing with another
+ * list-mutation primitive, such as hlist_add_head_rcu() or
+ * hlist_del_rcu(), running on this same list. However, it is
+ * perfectly legal to run concurrently with the _rcu list-traversal
+ * primitives, such as hlist_for_each_entry_rcu().
+ */
+static inline void hlist_del_init_rcu(struct hlist_node *n)
+{
+ if (!hlist_unhashed(n)) {
+ __hlist_del(n);
+ n->pprev = NULL;
}
}
next prev parent reply other threads:[~2008-06-05 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 15:36 [PATCH 0 of 3] mmu notifier v18 Andrea Arcangeli
2008-06-05 15:36 ` Andrea Arcangeli [this message]
2008-06-05 15:36 ` [PATCH 2 of 3] mm_take_all_locks Andrea Arcangeli
2008-06-05 16:15 ` Linus Torvalds
2008-06-05 16:44 ` [ofa-general] " Andrea Arcangeli
2008-06-05 15:36 ` [PATCH 3 of 3] mmu-notifier-core Andrea Arcangeli
-- strict thread matches above, loose matches on Subject: below --
2008-06-26 0:26 [PATCH 0 of 3] mmu notifier v18 for -mm Andrea Arcangeli
2008-06-26 0:26 ` [PATCH 1 of 3] list_del_init_rcu Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=becc195598f802256a03.1212680168@duo.random \
--to=andrea@qumranet.com \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=holt@sgi.c \
--cc=steiner@sgi.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox