Re: [PATCH v2 04/14] x86/cpufeatures: Assign dedicated feature word for AMD mem encryption

Sean Christopherson
2021-01-14T17:10:46Z

On Thu, Jan 14, 2021, Borislav Petkov wrote:
> On Wed, Jan 13, 2021 at 04:36:58PM -0800, Sean Christopherson wrote:
> > Collect the scattered SME/SEV related feature flags into a dedicated
> > word. There are now five recognized features in CPUID.0x8000001F.EAX,
> > with at least one more on the horizon (SEV-SNP). Using a dedicated word
> > allows KVM to use its automagic CPUID adjustment logic when reporting
> > the set of supported features to userspace.
> >
> > No functional change intended.
> >
> > Signed-off-by: Sean Christopherson <seanjc@google.com>
> > ---
>
> Subject should be:
>
> x86/cpufeatures: Assign dedicated feature word for CPUID_0x8000001F[EAX]
>
> but other than that, LGTM.
>
> Anything against me taking it through tip now?

Hmm, patch 05/14 depends on the existence of the new word. That's a non-issue
if you're planning on taking this for 5.11. If it's destined for 5.12, maybe
get an ack from Paolo on patch 05 and take both through tip? I can drop them
from this series when I send v3. In hindsight, I should have split these two
patches into a separate mini-series from the get-go.

Thanks!