From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33DE2C433F5 for ; Wed, 27 Apr 2022 16:25:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241668AbiD0Q2V (ORCPT ); Wed, 27 Apr 2022 12:28:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243339AbiD0Q1l (ORCPT ); Wed, 27 Apr 2022 12:27:41 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C8C9D36334 for ; Wed, 27 Apr 2022 09:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651076538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KCM+kR4pTupLxaN7Pzr4seAbVUE+H+zCFEJvKXyp008=; b=jJ5anBsONaEYO4X0BfrfQ+Un4bNCRDu4JZAZTRWZ/ZQKLnbDx7w86kepeRrBS6R0IJwqbc K2USzEuDxr6rLZHsYblCr3gjoeszs7VWXS8cGj6AK7M0+FzWgdC8dA/WxVGrWixeQXSWsY 7/jPDIZYrZG5AplhulholKE/ahw7jyc= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-416-WFCC1_xHP1Oz1QtdcOLvCQ-1; Wed, 27 Apr 2022 12:19:06 -0400 X-MC-Unique: WFCC1_xHP1Oz1QtdcOLvCQ-1 Received: by mail-ed1-f69.google.com with SMTP id co27-20020a0564020c1b00b00425ab566200so1272713edb.6 for ; Wed, 27 Apr 2022 09:19:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=KCM+kR4pTupLxaN7Pzr4seAbVUE+H+zCFEJvKXyp008=; b=hkqEtHiIyQPa07L0J+o9M1TiTp6xWw7SmvlTsERKh56wnFDfXluoupXTJF8sFOUe7f 3aqgsDy3NA6wZpg5Ovu9q/rtubsNjHaEDiV19625wdW7/R2D8sGKsYWXpFOKWcAXn0oO jbp75qgPBWOttMMmTNPw2VlzRrXG/mJn2Qjo1nSHG4FbghcLXhFscVThWVYHGOCsallO h6iWoU5FVXjytMuxU0rcXrQ0JalRP/TbjR+Zs4Hd4TSC+dassbEPb4OUVoOtguqw+bo6 dN2OLey3FBGpEC3dZFV2lrO+wrzAdhgOmuoNvP4bomamUgi7okGzGLhuWx1C9UV9Mpv2 GMGg== X-Gm-Message-State: AOAM531sPqGZO6T8367RlW1KN59GC4v6yJurQp2ArSNjUedz7OS9AX4X NFM4tP0lvkksfbZuI5Ukqz1//1AdpKGZKabHFzO6nE4nsDqRZc0eXvERaZw1dnK2fHQUzeP5Zt2 R3lWfAfQU2okv X-Received: by 2002:a05:6402:5201:b0:426:124:a40b with SMTP id s1-20020a056402520100b004260124a40bmr7129616edd.198.1651076345458; Wed, 27 Apr 2022 09:19:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxoHUy4nFsODaBAroyqMZG+PQ9rRZ5tD2/3U187eXKeQcTQ49CZmgADEk7rJYMAIQsQErds4g== X-Received: by 2002:a05:6402:5201:b0:426:124:a40b with SMTP id s1-20020a056402520100b004260124a40bmr7129587edd.198.1651076345207; Wed, 27 Apr 2022 09:19:05 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:1c09:f536:3de6:228c? ([2001:b07:6468:f312:1c09:f536:3de6:228c]) by smtp.googlemail.com with ESMTPSA id mb22-20020a170906eb1600b006f38dcf211bsm4894492ejb.138.2022.04.27.09.19.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Apr 2022 09:19:04 -0700 (PDT) Message-ID: Date: Wed, 27 Apr 2022 18:19:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH MANUALSEL 5.10 1/4] x86/kvm: Preserve BSP MSR_KVM_POLL_CONTROL across suspend/resume Content-Language: en-US To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wanpeng Li , Marcelo Tosatti , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, kvm@vger.kernel.org References: <20220427155435.19554-1-sashal@kernel.org> From: Paolo Bonzini In-Reply-To: <20220427155435.19554-1-sashal@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 4/27/22 17:54, Sasha Levin wrote: > From: Wanpeng Li > > [ Upstream commit 0361bdfddca20c8855ea3bdbbbc9c999912b10ff ] > > MSR_KVM_POLL_CONTROL is cleared on reset, thus reverting guests to > host-side polling after suspend/resume. Non-bootstrap CPUs are > restored correctly by the haltpoll driver because they are hot-unplugged > during suspend and hot-plugged during resume; however, the BSP > is not hotpluggable and remains in host-sde polling mode after > the guest resume. The makes the guest pay for the cost of vmexits > every time the guest enters idle. > > Fix it by recording BSP's haltpoll state and resuming it during guest > resume. > > Cc: Marcelo Tosatti > Signed-off-by: Wanpeng Li > Message-Id: <1650267752-46796-1-git-send-email-wanpengli@tencent.com> > Signed-off-by: Paolo Bonzini > Signed-off-by: Sasha Levin > --- > arch/x86/kernel/kvm.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > index 18e952fed021..6c3d38b5a8ad 100644 > --- a/arch/x86/kernel/kvm.c > +++ b/arch/x86/kernel/kvm.c > @@ -66,6 +66,7 @@ static DEFINE_PER_CPU_DECRYPTED(struct kvm_vcpu_pv_apf_data, apf_reason) __align > DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible; > static int has_steal_clock = 0; > > +static int has_guest_poll = 0; > /* > * No need for any "IO delay" on KVM > */ > @@ -624,14 +625,26 @@ static int kvm_cpu_down_prepare(unsigned int cpu) > > static int kvm_suspend(void) > { > + u64 val = 0; > + > kvm_guest_cpu_offline(false); > > +#ifdef CONFIG_ARCH_CPUIDLE_HALTPOLL > + if (kvm_para_has_feature(KVM_FEATURE_POLL_CONTROL)) > + rdmsrl(MSR_KVM_POLL_CONTROL, val); > + has_guest_poll = !(val & 1); > +#endif > return 0; > } > > static void kvm_resume(void) > { > kvm_cpu_online(raw_smp_processor_id()); > + > +#ifdef CONFIG_ARCH_CPUIDLE_HALTPOLL > + if (kvm_para_has_feature(KVM_FEATURE_POLL_CONTROL) && has_guest_poll) > + wrmsrl(MSR_KVM_POLL_CONTROL, 0); > +#endif > } > > static struct syscore_ops kvm_syscore_ops = { Acked-by: Paolo Bonzini