From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@bugzilla.kernel.org Subject: [Bug 190961] New: pvclock_gtod_notify invoked frequently leads to extra cpu load Date: Fri, 23 Dec 2016 08:39:21 +0000 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org Return-path: Received: from mail.kernel.org ([198.145.29.136]:52402 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750855AbcLWIj0 (ORCPT ); Fri, 23 Dec 2016 03:39:26 -0500 Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1356B203F4 for ; Fri, 23 Dec 2016 08:39:25 +0000 (UTC) Received: from bugzilla1.web.kernel.org (bugzilla1.web.kernel.org [172.20.200.51]) by mail.kernel.org (Postfix) with ESMTP id 227E9203B7 for ; Fri, 23 Dec 2016 08:39:22 +0000 (UTC) Sender: kvm-owner@vger.kernel.org List-ID: https://bugzilla.kernel.org/show_bug.cgi?id=190961 Bug ID: 190961 Summary: pvclock_gtod_notify invoked frequently leads to extra cpu load Product: Virtualization Version: unspecified Kernel Version: 4.9 Hardware: All OS: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: kvm Assignee: virtualization_kvm@kernel-bugs.osdl.org Reporter: yu.c.chen@intel.com Regression: No This thread is created for tracking purpose Currently the notifier of pvclock_gtod_notify() get invoked frequently due to the periodic update_wall_time(). This might slow down the system a little bit as there might be redundant execution code path and unnecessary lock contention in update_pvclock_gtod(), which was found when I was doing suspend/resume speed testings. As pvclock_gtod_notify() should be invoked only when clocksource has changed, according to Commit 16e8d74d2da9 ("KVM: x86: notifier for clocksource changes") , either we can add a new notifier for clocksource switch, or we can simply bypass the following code in pvclock_gtod_notify() earlier if there is no clocksource switch. https://patchwork.kernel.org/patch/9487257/ -- You are receiving this mail because: You are watching the assignee of the bug.