kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: kvm@kernel.org
Subject: [Bug 197861] Shutting down a VM with Kernel 4.14 will sometime hang and a reboot is the only way to recover.
Date: Tue, 12 Dec 2017 22:13:30 +0000	[thread overview]
Message-ID: <bug-197861-28872-v1eWrGHiOx@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-197861-28872@https.bugzilla.kernel.org/>

https://bugzilla.kernel.org/show_bug.cgi?id=197861

Willem de Bruijn (willemb@google.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |willemb@google.com

--- Comment #6 from Willem de Bruijn (willemb@google.com) ---
Does reverting only that patch resolve the issue?

The logic in it is quite complex, but it is only needed for zerocopy with
MSG_ZEROCOPY. And then only in edge cases.

This is likely not used here. The code is blocking on vhost_net use of
zerocopy. Which does not build skbuffs with zerocopy data in compound pages.

The patch adds checks against shared and cloned skbs that were not present
before. It is not safe to modify skb frags[] on on either, but perhaps this
changed return path causes buffers to not be released, causing
vhost_net_ubuf_put_and_wait to wait seemingly indefinitely.

+       if (skb_shared(skb) || skb_unclone(skb, gfp_mask))
+               return -EINVAL;

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

  parent reply	other threads:[~2017-12-12 22:13 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-13 15:35 [Bug 197861] New: Shutting down a VM with Kernel 4.14 will sometime hang and a reboot is the only way to recover bugzilla-daemon
2017-12-04 20:33 ` [Bug 197861] " bugzilla-daemon
2017-12-11 11:34 ` bugzilla-daemon
2017-12-12 18:55 ` bugzilla-daemon
2017-12-12 19:15 ` bugzilla-daemon
2017-12-12 19:18 ` bugzilla-daemon
2017-12-12 22:13 ` bugzilla-daemon [this message]
2017-12-12 22:25 ` bugzilla-daemon
2017-12-13  3:48 ` bugzilla-daemon
2017-12-13  4:21 ` bugzilla-daemon
2017-12-13  4:22 ` bugzilla-daemon
2017-12-13 18:05 ` bugzilla-daemon
2017-12-13 19:17 ` bugzilla-daemon
2017-12-13 20:27 ` bugzilla-daemon
2017-12-13 22:48 ` bugzilla-daemon
2017-12-13 23:09 ` bugzilla-daemon
2017-12-14  1:54 ` bugzilla-daemon
2017-12-14  2:36 ` bugzilla-daemon
2017-12-14  3:23 ` bugzilla-daemon
2017-12-14 17:39 ` bugzilla-daemon
2017-12-14 17:58 ` bugzilla-daemon
2017-12-14 18:06 ` bugzilla-daemon
2017-12-27  4:00 ` bugzilla-daemon
2017-12-27 16:58 ` bugzilla-daemon
2017-12-27 17:40 ` bugzilla-daemon
2017-12-27 17:50 ` bugzilla-daemon
2017-12-27 19:22 ` bugzilla-daemon
2017-12-27 22:04 ` bugzilla-daemon
2017-12-27 23:26 ` bugzilla-daemon
2017-12-28 17:20 ` bugzilla-daemon
2018-01-01 16:01 ` bugzilla-daemon
2018-01-02 10:01 ` bugzilla-daemon
2018-01-02 13:33 ` bugzilla-daemon
2018-01-02 16:43 ` bugzilla-daemon
2018-01-03  9:35 ` bugzilla-daemon
2018-01-03 11:41 ` bugzilla-daemon
2018-01-04 22:55 ` bugzilla-daemon
2018-01-10 13:21 ` bugzilla-daemon
2018-01-10 14:25 ` bugzilla-daemon
2018-01-15 13:26 ` bugzilla-daemon
2018-01-15 13:33 ` bugzilla-daemon
2018-01-15 13:34 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-197861-28872-v1eWrGHiOx@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=kvm@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).