[Bug 205477] New: Useless address check in function __kvm_set_memory_region()

[Bug 205477] New: Useless address check in function __kvm_set_memory_region()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=205477

            Bug ID: 205477
           Summary: Useless address check in function
                    __kvm_set_memory_region()
           Product: Virtualization
           Version: unspecified
    Kernel Version: 5.2.0
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: low
          Priority: P1
         Component: kvm
          Assignee: virtualization_kvm@kernel-bugs.osdl.org
          Reporter: alexandr.sky@gmail.com
        Regression: No

In function __kvm_set_memory_region() at virt/kvm/kvm_main.c:950, the condition
is false in any case.

950          if (mem->guest_phys_addr + mem->memory_size <
mem->guest_phys_addr)
951                  goto out;

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 205477] Useless address check in function __kvm_set_memory_region()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=205477

Sean Christopherson (sean.j.christopherson@intel.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sean.j.christopherson@intel
                   |                            |.com

--- Comment #1 from Sean Christopherson (sean.j.christopherson@intel.com) ---
No, the check catches cases where @mem wraps to zero, e.g. guest_phys_addr =
0xfffffffffffff000 and memory_size >= 0x1000.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 205477] Useless address check in function __kvm_set_memory_region()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=205477

Alexandr Ivanov (alexandr.sky@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Alexandr Ivanov (alexandr.sky@gmail.com) ---
(In reply to Sean Christopherson from comment #1)
> No, the check catches cases where @mem wraps to zero, e.g. guest_phys_addr =
> 0xfffffffffffff000 and memory_size >= 0x1000.

Oh, sorry, I hadn't caught the idea.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.