From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DECE0C38BE2 for ; Mon, 24 Feb 2020 20:36:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A809121927 for ; Mon, 24 Feb 2020 20:36:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727323AbgBXUgo convert rfc822-to-8bit (ORCPT ); Mon, 24 Feb 2020 15:36:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:50988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726722AbgBXUgo (ORCPT ); Mon, 24 Feb 2020 15:36:44 -0500 From: bugzilla-daemon@bugzilla.kernel.org To: kvm@vger.kernel.org Subject: [Bug 206579] KVM with passthrough generates "BUG: kernel NULL pointer dereference" and crashes Date: Mon, 24 Feb 2020 20:36:43 +0000 X-Bugzilla-Reason: None X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: AssignedTo virtualization_kvm@kernel-bugs.osdl.org X-Bugzilla-Product: Virtualization X-Bugzilla-Component: kvm X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: rmuncrief@humanavance.com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: virtualization_kvm@kernel-bugs.osdl.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org https://bugzilla.kernel.org/show_bug.cgi?id=206579 --- Comment #13 from muncrief (rmuncrief@humanavance.com) --- Created attachment 287585 --> https://bugzilla.kernel.org/attachment.cgi?id=287585&action=edit dmesg crash output with Paolo's latest patch Hi Paolo. I changed the patch, however it doesn't compile with exactly what you suggested. You said "!irqchip_in_kernel(vcpu->kvm)" but svm is what's passed to the function so I had to change it to "!irqchip_in_kernel(&svm->vcpu.kvm)" or compilation failed. So to be clear the new patch I applied was: \- if (!kvm_vcpu_apicv_active(&svm->vcpu)) \+ if (!avic && !irqchip_in_kernel(svm->vcpu.kvm)) return 0; ret = avic_init_backing_page(&svm->vcpu); However kvm still crashes at boot with the patch from Comment 4 and the new patch applied. I've attached the dmesg output to this comment. The qemu command is coming up because I don't see how to attach two files. -- You are receiving this mail because: You are watching the assignee of the bug.