From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03AE7C55179 for ; Wed, 28 Oct 2020 21:52:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 910E524724 for ; Wed, 28 Oct 2020 21:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728324AbgJ1VwZ convert rfc822-to-8bit (ORCPT ); Wed, 28 Oct 2020 17:52:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:45024 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728307AbgJ1VwX (ORCPT ); Wed, 28 Oct 2020 17:52:23 -0400 From: bugzilla-daemon@bugzilla.kernel.org To: kvm@vger.kernel.org Subject: [Bug 209253] Loss of connectivity on guest after important host <-> guest traffic Date: Wed, 28 Oct 2020 20:35:22 +0000 X-Bugzilla-Reason: None X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: AssignedTo virtualization_kvm@kernel-bugs.osdl.org X-Bugzilla-Product: Virtualization X-Bugzilla-Component: kvm X-Bugzilla-Version: unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: alex.williamson@redhat.com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: virtualization_kvm@kernel-bugs.osdl.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org https://bugzilla.kernel.org/show_bug.cgi?id=209253 --- Comment #12 from Alex Williamson (alex.williamson@redhat.com) --- Created attachment 293281 --> https://bugzilla.kernel.org/attachment.cgi?id=293281&action=edit Test fix for ioeventfd_write traces For those experiencing the issue described by Ian in comment 1 and the first issue from Martin in comment 2, please try this patch if you're able. vfio_pci_ioeventfd_handler() is called in a spinlock context with interrupts disabled and tries to acquire a read lock on the memory semaphore to verify the device memory is enabled. The down_read() call can sleep and therefore should instead be called from a thread context if there is contention. TBH, I've never seen it contended, so in practice the thread is never really used, but this seems to solve the specific case Ian has identified and it would have been introduced by the commit noted in comment 5. This change should be specific to configurations with NVIDIA GPUs assigned. I'm curious about the traces with vfio_msihandler as well, if anyone can provide a reproducer of that it would be appreciated. -- You are receiving this mail because: You are watching the assignee of the bug.