[Bug 220963] New: nSVM: missing unmap in nested_svm_vmrun()

[Bug 220963] New: nSVM: missing unmap in nested_svm_vmrun()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=220963

            Bug ID: 220963
           Summary: nSVM: missing unmap in nested_svm_vmrun()
           Product: Virtualization
           Version: unspecified
          Hardware: AMD
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: kvm
          Assignee: virtualization_kvm@kernel-bugs.osdl.org
          Reporter: max@m00nbsd.net
        Regression: No

In nested_svm_vmrun():

    ret = kvm_vcpu_map(vcpu, gpa_to_gfn(vmcb12_gpa), &map);
...
    if (WARN_ON_ONCE(!svm->nested.initialized))
        return -EINVAL;

A call to kvm_vcpu_unmap() is missing before the return.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

Re: [Bug 220963] New: nSVM: missing unmap in nested_svm_vmrun()

[Yosry Ahmed]

On Sat, Jan 10, 2026 at 07:33:25PM +0000, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=220963
> 
>             Bug ID: 220963
>            Summary: nSVM: missing unmap in nested_svm_vmrun()
>            Product: Virtualization
>            Version: unspecified
>           Hardware: AMD
>                 OS: Linux
>             Status: NEW
>           Severity: normal
>           Priority: P3
>          Component: kvm
>           Assignee: virtualization_kvm@kernel-bugs.osdl.org
>           Reporter: max@m00nbsd.net
>         Regression: No
> 
> In nested_svm_vmrun():
> 
>     ret = kvm_vcpu_map(vcpu, gpa_to_gfn(vmcb12_gpa), &map);
> ...
>     if (WARN_ON_ONCE(!svm->nested.initialized))
>         return -EINVAL;
> 
> A call to kvm_vcpu_unmap() is missing before the return.

I think I accidentally fixed this in
https://lore.kernel.org/kvm/20251215192722.3654335-26-yosry.ahmed@linux.dev/.

It's probably not a big deal, as reaching nested_svm_vmrun() without
svm->nested.initialized means we already have another bug :)

> 
> -- 
> You may reply to this email to add a comment.
> 
> You are receiving this mail because:
> You are watching the assignee of the bug.

[Bug 220963] nSVM: missing unmap in nested_svm_vmrun()

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=220963

--- Comment #1 from yosry.ahmed@linux.dev ---
On Sat, Jan 10, 2026 at 07:33:25PM +0000, bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=220963
> 
>             Bug ID: 220963
>            Summary: nSVM: missing unmap in nested_svm_vmrun()
>            Product: Virtualization
>            Version: unspecified
>           Hardware: AMD
>                 OS: Linux
>             Status: NEW
>           Severity: normal
>           Priority: P3
>          Component: kvm
>           Assignee: virtualization_kvm@kernel-bugs.osdl.org
>           Reporter: max@m00nbsd.net
>         Regression: No
> 
> In nested_svm_vmrun():
> 
>     ret = kvm_vcpu_map(vcpu, gpa_to_gfn(vmcb12_gpa), &map);
> ...
>     if (WARN_ON_ONCE(!svm->nested.initialized))
>         return -EINVAL;
> 
> A call to kvm_vcpu_unmap() is missing before the return.

I think I accidentally fixed this in
https://lore.kernel.org/kvm/20251215192722.3654335-26-yosry.ahmed@linux.dev/.

It's probably not a big deal, as reaching nested_svm_vmrun() without
svm->nested.initialized means we already have another bug :)

> 
> -- 
> You may reply to this email to add a comment.
> 
> You are receiving this mail because:
> You are watching the assignee of the bug.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.