kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: bugzilla-daemon@bugzilla.kernel.org
To: kvm@vger.kernel.org
Subject: [Bug 42812] New: kvm module has bogus kernel version check
Date: Wed, 22 Feb 2012 22:53:32 GMT	[thread overview]
Message-ID: <bug-42812-28872@https.bugzilla.kernel.org/> (raw)

https://bugzilla.kernel.org/show_bug.cgi?id=42812

           Summary: kvm module has bogus kernel version check
           Product: Virtualization
           Version: unspecified
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: kvm
        AssignedTo: virtualization_kvm@kernel-bugs.osdl.org
        ReportedBy: mcbbzko@robuust.nl
        Regression: No


In kvm-kmod-3.2, x86/external-module-compat.h, line 1102 the following check is
present:

#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37) || \
    (LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) && KERNEL_EXTRAVERSION < 40)

The second half is bogus, since if kernel version is 2.6.32, it would have
matched the < 2.6.37 anyway.
Maybe the 2,6,32 should read 2,6,37 instead? (that would make more sense, but
may not be right!)

This check appears to be present since kvm-kmod release 3.0b, which makes it
unlikely many people tried it with 2.6.27.40+ kernels and found it to be a
problem...

--
Maarten

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

             reply	other threads:[~2012-02-22 22:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-22 22:53 bugzilla-daemon [this message]
2012-02-28 17:29 ` [Bug 42812] kvm module has bogus kernel version check bugzilla-daemon
2012-05-12  2:13 ` bugzilla-daemon
2012-05-12  2:13 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-42812-28872@https.bugzilla.kernel.org/ \
    --to=bugzilla-daemon@bugzilla.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).