From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@bugzilla.kernel.org Subject: [Bug 42812] New: kvm module has bogus kernel version check Date: Wed, 22 Feb 2012 22:53:32 GMT Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" To: kvm@vger.kernel.org Return-path: Received: from bugzilla.kernel.org ([198.145.19.204]:53491 "EHLO bugzilla.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751013Ab2BVWxd (ORCPT ); Wed, 22 Feb 2012 17:53:33 -0500 Received: from bugzilla.kernel.org (localhost [127.0.0.1]) by bugzilla.kernel.org (8.14.5/8.14.5) with ESMTP id q1MMrWio031658 for ; Wed, 22 Feb 2012 22:53:32 GMT Sender: kvm-owner@vger.kernel.org List-ID: https://bugzilla.kernel.org/show_bug.cgi?id=42812 Summary: kvm module has bogus kernel version check Product: Virtualization Version: unspecified Platform: All OS/Version: Linux Tree: Mainline Status: NEW Severity: normal Priority: P1 Component: kvm AssignedTo: virtualization_kvm@kernel-bugs.osdl.org ReportedBy: mcbbzko@robuust.nl Regression: No In kvm-kmod-3.2, x86/external-module-compat.h, line 1102 the following check is present: #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37) || \ (LINUX_VERSION_CODE == KERNEL_VERSION(2,6,32) && KERNEL_EXTRAVERSION < 40) The second half is bogus, since if kernel version is 2.6.32, it would have matched the < 2.6.37 anyway. Maybe the 2,6,32 should read 2,6,37 instead? (that would make more sense, but may not be right!) This check appears to be present since kvm-kmod release 3.0b, which makes it unlikely many people tried it with 2.6.27.40+ kernels and found it to be a problem... -- Maarten -- Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching the assignee of the bug.