From mboxrd@z Thu Jan 1 00:00:00 1970
From: bugzilla-daemon@bugzilla.kernel.org
Subject: [Bug 43339] New: Wrong Pci-Bridge Header Type check.
Date: Mon, 4 Jun 2012 14:28:45 +0000 (UTC)
Message-ID:
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
To: kvm@vger.kernel.org
Return-path:
Received: from mail.kernel.org ([198.145.19.201]:55194 "EHLO mail.kernel.org"
rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
id S1752255Ab2FDO2s (ORCPT );
Mon, 4 Jun 2012 10:28:48 -0400
Received: from mail.kernel.org (localhost [127.0.0.1])
by mail.kernel.org (Postfix) with ESMTP id 2A2F4202B9
for ; Mon, 4 Jun 2012 14:28:46 +0000 (UTC)
Received: from bugzilla.kernel.org (bugzilla.kernel.org [198.145.19.204])
by mail.kernel.org (Postfix) with ESMTP id 091A1202B4
for ; Mon, 4 Jun 2012 14:28:45 +0000 (UTC)
Sender: kvm-owner@vger.kernel.org
List-ID:
https://bugzilla.kernel.org/show_bug.cgi?id=43339
Summary: Wrong Pci-Bridge Header Type check.
Product: Virtualization
Version: unspecified
Kernel Version: 3.4
Platform: All
OS/Version: Linux
Tree: Mainline
Status: NEW
Severity: normal
Priority: P1
Component: kvm
AssignedTo: virtualization_kvm@kernel-bugs.osdl.org
ReportedBy: vedun@ispras.ru
Regression: No
I have found bug in file virt/kvm/assigned-device.c
670 /* Don't allow bridges to be assigned */
671 pci_read_config_byte(dev, PCI_HEADER_TYPE, &header_type);
672 if ((header_type & PCI_HEADER_TYPE) != PCI_HEADER_TYPE_NORMAL) {
673 r = -EPERM;
674 goto out_put;
675 }
This code doesn't check that device is PCI-Bridge. In my case
header_type is 1, default value for PCI-Bridge
PCI_HEADER_TYPE is 14(0xE)
PCI_HEADER_TYPE_NORMAL is 0
So, 1 & 0xE == 0 thus KVM assigns pci-bridge device to VM successfully.
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.