Re: [PATCH v3 01/16] x86/tdx: Move all TDX error defines into

Huang, Kai
2025-09-25T23:32:07Z

On Thu, 2025-09-25 at 23:23 +0000, Edgecombe, Rick P wrote:
> On Fri, 2025-09-19 at 01:29 +0000, Huang, Kai wrote:
> > The existing asm/shared/tdx.h is used for sharing TDX code between the
> > early compressed code and the normal kernel code after that, i.e., it's
> > not for sharing between TDX guest and host.
> >
> > Any reason to put the new tdx_errno.h under asm/shared/ ?
>
> Well this series doesn't address this, but the compressed code could use
> IS_TDX_SUCCESS(), etc. I assume the purpose was to put it in a place where all
> callers could use them.

Sure.

>
> If you think that is good reasoning too, then I think it's worth mentioning in
> the log.

I am fine either way.

Since (as you said) compressed code isn't changed to use IS_TDX_xx() in
this series, it's hard to see the reason (from the code change) why you
put it under asm/shared/ w/o explaining it in the changelog.