Re: [PATCH 3/8] target/ppc/mmu: Remove unused hash32_store_hpte() helpers

[Harsh Prateek Bora <harshpb@linux.ibm.com>]

On 19/03/26 4:49 pm, Philippe Mathieu-Daudé wrote:
> The hash32_store_hpte() helpers are unused since commit
> 6e8a65abbbd ("ppc/hash32: Rework R and C bit updates"),
> 7 years ago. Remove them.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com>

> ---
>   target/ppc/mmu-hash32.h | 16 ----------------
>   1 file changed, 16 deletions(-)
> 
> diff --git a/target/ppc/mmu-hash32.h b/target/ppc/mmu-hash32.h
> index 04c23ea75ed..5705f57935b 100644
> --- a/target/ppc/mmu-hash32.h
> +++ b/target/ppc/mmu-hash32.h
> @@ -87,22 +87,6 @@ static inline target_ulong ppc_hash32_load_hpte1(PowerPCCPU *cpu,
>       return ldl_phys(CPU(cpu)->as, base + pte_offset + HASH_PTE_SIZE_32 / 2);
>   }
>   
> -static inline void ppc_hash32_store_hpte0(PowerPCCPU *cpu,
> -                                          hwaddr pte_offset, target_ulong pte0)
> -{
> -    target_ulong base = ppc_hash32_hpt_base(cpu);
> -
> -    stl_phys(CPU(cpu)->as, base + pte_offset, pte0);
> -}
> -
> -static inline void ppc_hash32_store_hpte1(PowerPCCPU *cpu,
> -                                          hwaddr pte_offset, target_ulong pte1)
> -{
> -    target_ulong base = ppc_hash32_hpt_base(cpu);
> -
> -    stl_phys(CPU(cpu)->as, base + pte_offset + HASH_PTE_SIZE_32 / 2, pte1);
> -}
> -
>   static inline hwaddr get_pteg_offset32(PowerPCCPU *cpu, hwaddr hash)
>   {
>       return (hash * HASH_PTEG_SIZE_32) & ppc_hash32_hpt_mask(cpu);