From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 04/17] tools/kvm_stat: fix misc glitches Date: Fri, 10 Mar 2017 11:05:51 +0100 Message-ID: References: <20170220154211.11882-1-raspl@linux.vnet.ibm.com> <20170220154211.11882-5-raspl@linux.vnet.ibm.com> <961ec6b4-7dfe-7b86-2dc0-16e3e0d99205@redhat.com> <4929cf77-378b-7183-9b69-7f6cfeecb077@linux.vnet.ibm.com> <766744941.327830.1489133657474.JavaMail.zimbra@redhat.com> <7e65c785-f23d-12d1-222c-087d0572f30c@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, rkrcmar@redhat.com, frankja@linux.vnet.ibm.com To: raspl@linux.vnet.ibm.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40248 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933511AbdCJKF7 (ORCPT ); Fri, 10 Mar 2017 05:05:59 -0500 In-Reply-To: <7e65c785-f23d-12d1-222c-087d0572f30c@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 10/03/2017 10:42, Stefan Raspl wrote: >>> Ah, sorry, missed the first chunk: That was to eliminate unused >>> variable 'libc'. >> It's not unused, it's used on the following line. :) > Sorry, don't want to get annoying: Yeah, right, so I was eliminating > that variable - do you want me to remove the chunk from the patch? Yes, please. >>> As for the "3.": I noticed through pylint, PEP8 is fine. Seemed >>> valid to me, but in the grand scheme of things it certainly doesn't >>> matter (and wasn't aware it becomes moot in Python 3), so I'd take >>> it out if you want. >> I think it's a valid complaint with Python 2 division. If pylint >> complaints even with "from __future__ import division", it would be a >> pylint bug in my opinion. >> >> Maybe it's just me... I wouldn't have complained about "3.0" for example. :) > Tried the import, pylint still complains :O > So: Just switch to 3.0 here and in 07/17, and repost? And this too. Thanks, Paolo