Re: [kvm-unit-tests PATCH v3 00/11] s390x: Cleanup and maintenance 4

[Janosch Frank <frankja@linux.ibm.com>]

On 4/21/22 13:59, Claudio Imbrenda wrote:
> On Thu, 21 Apr 2022 10:11:19 +0000
> Janosch Frank <frankja@linux.ibm.com> wrote:
> 
>> A few small cleanups and two patches that I forgot to upstream which
>> have now been rebased onto the machine.h library functions.
> 
> thanks, queued
> 

Please drop the register restore patch #11 from your queue.

Nico rightly complained that r0/r1 are volatile and I shouldn't have to 
restore them. It's been too long for me to fully remember why I had to 
fix that. It might have been a diag308 wrongfully resetting all 
registers but not loading the reset PSW. Whatever issue I had, the 
commit message is wrong anyway. If I'm able to remember the issue I'll 
fix and post the patch again.

>>
>> v3:
>> 	* Added review tags
>> 	* Added uv-host and diag308 fix
>> 	* Diag308 subcode 2 patch, moved the prefix push and pop outside of the if
>>
>> v2:
>> 	* Added host_is_qemu() function
>> 	* Fixed qemu checks
>>
>> Janosch Frank (11):
>>    lib: s390x: hardware: Add host_is_qemu() function
>>    s390x: css: Skip if we're not run by qemu
>>    s390x: diag308: Only test subcode 2 under QEMU
>>    s390x: pfmf: Initialize pfmf_r1 union on declaration
>>    s390x: snippets: asm: Add license and copyright headers
>>    s390x: pv-diags: Cleanup includes
>>    s390x: css: Cleanup includes
>>    s390x: iep: Cleanup includes
>>    s390x: mvpg: Cleanup includes
>>    s390x: uv-host: Fix pgm tests
>>    s390x: Restore registers in diag308_load_reset() error path
>>
>>   lib/s390x/hardware.h                       |  5 +++
>>   s390x/cpu.S                                |  1 +
>>   s390x/css.c                                | 18 ++++++----
>>   s390x/diag308.c                            | 18 +++++++++-
>>   s390x/iep.c                                |  3 +-
>>   s390x/mvpg.c                               |  3 --
>>   s390x/pfmf.c                               | 39 +++++++++++-----------
>>   s390x/pv-diags.c                           | 17 ++--------
>>   s390x/snippets/asm/snippet-pv-diag-288.S   |  9 +++++
>>   s390x/snippets/asm/snippet-pv-diag-500.S   |  9 +++++
>>   s390x/snippets/asm/snippet-pv-diag-yield.S |  9 +++++
>>   s390x/uv-host.c                            |  2 +-
>>   12 files changed, 85 insertions(+), 48 deletions(-)
>>
>