From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>
Subject: Re: [PATCH v2 2/3] KVM: LAPIC: lapic timer interrupt is injected by posted interrupt
Date: Tue, 11 Jun 2019 13:40:03 +0200 [thread overview]
Message-ID: <c5530947-d48d-e3da-3056-ed64f7fa9a9d@redhat.com> (raw)
In-Reply-To: <1559799086-13912-3-git-send-email-wanpengli@tencent.com>
On 06/06/19 07:31, Wanpeng Li wrote:
> +static inline bool can_posted_interrupt_inject_timer(struct kvm_vcpu *vcpu)
> +{
> + return posted_interrupt_inject_timer_enabled(vcpu) &&
> + !vcpu_halt_in_guest(vcpu);
> +}
> +
I agree with Radim, what you want here is just use kvm_hlt_in_guest.
I'll post shortly a prerequisite patch to block APF artificial halt when
kvm_hlt_in_guest is true.
Paolo
next prev parent reply other threads:[~2019-06-11 11:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 5:31 [PATCH v2 0/3] KVM: LAPIC: Implement Exitless Timer Wanpeng Li
2019-06-06 5:31 ` [PATCH v2 1/3] KVM: LAPIC: Make lapic timer unpinned when timer is injected by posted-interrupt Wanpeng Li
2019-06-10 17:11 ` Radim Krčmář
2019-06-11 8:31 ` Wanpeng Li
2019-06-06 5:31 ` [PATCH v2 2/3] KVM: LAPIC: lapic timer interrupt is injected by posted interrupt Wanpeng Li
2019-06-10 16:51 ` Radim Krčmář
2019-06-11 8:18 ` Wanpeng Li
2019-06-11 11:40 ` Paolo Bonzini [this message]
2019-06-11 12:18 ` Wanpeng Li
2019-06-06 5:31 ` [PATCH v2 3/3] KVM: LAPIC: Ignore timer migration when lapic timer is injected by posted-interrupt Wanpeng Li
2019-06-06 10:55 ` [PATCH v2 4/3] KVM: LAPIC: add advance timer support to pi_inject_timer Wanpeng Li
2019-06-10 4:32 ` [PATCH v2 0/3] KVM: LAPIC: Implement Exitless Timer Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5530947-d48d-e3da-3056-ed64f7fa9a9d@redhat.com \
--to=pbonzini@redhat.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox