From: linmiaohe <linmiaohe@huawei.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: nVMX: Remove stale comment from nested_vmx_load_cr3()
Date: Wed, 5 Feb 2020 01:57:43 +0000 [thread overview]
Message-ID: <c587f9fff1ec45709af5a453df94d92b@huawei.com> (raw)
Sean Christopherson <sean.j.christopherson@intel.com> writes:
> The blurb pertaining to the return value of nested_vmx_load_cr3() no longer matches reality, remove it entirely as the behavior it is attempting to document is quite obvious when reading the actual code.
>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> - * Returns 0 on success, 1 on failure. Invalid state exit qualification code
> - * is assigned to entry_failure_code on failure.
> */
> static int nested_vmx_load_cr3(struct kvm_vcpu *vcpu, unsigned long cr3, bool nested_ept,
> u32 *entry_failure_code)
It seems the comment is uncorrect as it return -EINVAL on failure. Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@huawei.com>
next reply other threads:[~2020-02-05 1:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 1:57 linmiaohe [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-04 15:32 [PATCH] KVM: nVMX: Remove stale comment from nested_vmx_load_cr3() Sean Christopherson
2020-02-04 16:15 ` Vitaly Kuznetsov
2020-02-04 19:57 ` Krish Sadhukhan
2020-02-04 20:36 ` Sean Christopherson
2020-02-04 22:01 ` Krish Sadhukhan
2020-02-05 14:31 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c587f9fff1ec45709af5a453df94d92b@huawei.com \
--to=linmiaohe@huawei.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox