Re: [PATCH v4 6/6] KVM: x86: Refactor __kvm_emulate_hypercall() into a macro

Paolo Bonzini
2024-12-10T16:20:39Z

On 11/28/24 09:38, Adrian Hunter wrote:
>
> For TDX, there is an RFC relating to using descriptively
> named parameters instead of register names for tdh_vp_enter():
>
> https://lore.kernel.org/all/fa817f29-e3ba-4c54-8600-e28cf6ab1953@intel.com/
>
> Please do give some feedback on that approach. Note we
> need both KVM and x86 maintainer approval for SEAMCALL
> wrappers like tdh_vp_enter().
>
> As proposed, that ends up with putting the values back into
> vcpu->arch.regs[] for __kvm_emulate_hypercall() which is not
> pretty:

If needed we can revert this patch, it's not a big problem.

Paolo